From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96623 invoked by alias); 22 Oct 2015 13:49:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 96598 invoked by uid 89); 22 Oct 2015 13:49:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: e06smtp05.uk.ibm.com Received: from e06smtp05.uk.ibm.com (HELO e06smtp05.uk.ibm.com) (195.75.94.101) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Thu, 22 Oct 2015 13:49:58 +0000 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 22 Oct 2015 14:49:54 +0100 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 22 Oct 2015 14:49:53 +0100 X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com X-IBM-MailFrom: uweigand@de.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 7AB9A1B0806E for ; Thu, 22 Oct 2015 14:50:01 +0100 (BST) Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t9MDnri858654806 for ; Thu, 22 Oct 2015 13:49:53 GMT Received: from d06av07.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t9MDnq7k023695 for ; Thu, 22 Oct 2015 07:49:52 -0600 Received: from oc7340732750.ibm.com (dyn-9-152-213-152.boeblingen.de.ibm.com [9.152.213.152]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t9MDnqRT023686; Thu, 22 Oct 2015 07:49:52 -0600 Received: by oc7340732750.ibm.com (Postfix, from userid 500) id 1AF5AF738; Thu, 22 Oct 2015 15:49:52 +0200 (CEST) Subject: Re: [PATCH v3 2/5] Support breakpoint kinds for software breakpoints in GDBServer. To: antoine.tremblay@ericsson.com (Antoine Tremblay) Date: Thu, 22 Oct 2015 15:17:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, antoine.tremblay@ericsson.com (Antoine Tremblay), palves@redhat.com In-Reply-To: <1445359685-2589-3-git-send-email-antoine.tremblay@ericsson.com> from "Antoine Tremblay" at Oct 20, 2015 12:48:02 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <20151022134952.1AF5AF738@oc7340732750.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15102213-0021-0000-0000-0000048EE82E X-SW-Source: 2015-10/txt/msg00467.txt.bz2 Antoine Tremblay wrote: > gdb/gdbserver/ChangeLog: > * mem-break.c : Remove breakpoint_data/breakpoint_len global variables. > (set_breakpoint_data): Remove. This breaks building gdbserver for spu-elf: spu-low.o: In function `initialize_low': gdb/gdbserver/spu-low.c:684: undefined reference to `set_breakpoint_data' and most likely other non-Linux gdbserver targets that still refer to set_breakpoint_data: gdb/gdbserver/nto-low.c: set_breakpoint_data (the_low_target.breakpoint, gdb/gdbserver/win32-low.c: set_breakpoint_data (the_low_target.breakpoint, What needs to be done to fix those? B.t.w. if set_breakpoint_data is really gone, its prototype should be removed from mem-break.h as well. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com