From: Antoine Tremblay <antoine.tremblay@ericsson.com>
To: Yao Qi <qiyaoltc@gmail.com>, Pedro Alves <palves@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH v3 0/5] Software breakpoints support for ARM linux in GDBServer.
Date: Wed, 21 Oct 2015 19:31:00 -0000 [thread overview]
Message-ID: <5627B12A.9050104@ericsson.com> (raw)
In-Reply-To: <86zizc1dor.fsf@gmail.com>
On 10/21/2015 10:47 AM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>> I replied to all patches individually, and in general this all LGTM now.
>> Feel free to push with the nits I pointed out fixed, if Yao is happy with
>> it as well.
>
> With these things Pedro pointed out fixed, these patches look good to me too.
>
This is now pushed in.
Thanks for the review!
prev parent reply other threads:[~2015-10-21 15:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 16:48 Antoine Tremblay
2015-10-20 16:48 ` [PATCH v3 1/5] Add the target_ops needed for software breakpoints " Antoine Tremblay
2015-10-21 11:22 ` Pedro Alves
2015-10-20 16:48 ` [PATCH v3 5/5] Support software breakpoints for ARM linux " Antoine Tremblay
2015-10-21 13:12 ` Pedro Alves
2015-10-20 16:49 ` [PATCH v3 4/5] Refactor the breakpoint definitions in linux-arm-low.c Antoine Tremblay
2015-10-21 13:04 ` Pedro Alves
2015-10-20 16:49 ` [PATCH v3 2/5] Support breakpoint kinds for software breakpoints in GDBServer Antoine Tremblay
2015-10-21 11:49 ` Pedro Alves
2015-10-21 14:19 ` Antoine Tremblay
2015-10-21 14:23 ` Pedro Alves
2015-10-21 14:41 ` Antoine Tremblay
2015-10-22 15:17 ` Ulrich Weigand
2015-10-22 15:54 ` Antoine Tremblay
2015-10-20 16:55 ` [PATCH v3 3/5] Implement breakpoint_kind_from_pc and sw_breakpoint_from_kind for ARM " Antoine Tremblay
2015-10-21 12:04 ` Pedro Alves
2015-10-21 13:34 ` [PATCH v3 0/5] Software breakpoints support for ARM linux " Pedro Alves
2015-10-21 18:44 ` Yao Qi
2015-10-21 19:31 ` Antoine Tremblay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5627B12A.9050104@ericsson.com \
--to=antoine.tremblay@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox