From: Joel Brobecker <brobecker@adacore.com>
To: Pierre-Marie de Rodat <derodat@adacore.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Share the "multi_line" helper among all Ada testcases
Date: Tue, 17 Mar 2015 20:08:00 -0000 [thread overview]
Message-ID: <20150317200809.GD7494@adacore.com> (raw)
In-Reply-To: <54FEDB92.9060808@adacore.com>
> This patch is a tiny cleanup for the Ada testsuite: it put the
> "multi_line" helper (currently defined in 6 testcases) in a common
> place: ada.exp. It triggers no regression (tested on x86_64-linux).
>
> Ok to push?
> Thank you in advance,
>
> gdb/testsuite/ChangeLog:
> 2015-03-10 Pierre-Marie de Rodat <derodat@adacore.com>
>
> * gdb.ada/complete.exp: Remove "multi_line".
> * gdb.ada/info_exc.exp: Remove "multi_line".
> * gdb.ada/packed_tagged.exp: Remove "multi_line".
> * gdb.ada/ptype_field.exp: Remove "multi_line".
> * gdb.ada/sym_print_name.exp: Remove "multi_line".
> * gdb.ada/tagged.exp: Remove "multi_line".
> * lib/ada.exp: Add the "multi_line" helper.
At the time I introduced this function, I thought it should even
be in gdb.exp, but others did not agree with its usefulness, which
explains why I ended up duplicating it everywhere.
Let's do the following: Let's give people a week to comment on
this, and if there are no objection, let's put it in ada.exp.
If others agree that this should be in gdb.exp, then let's do that
instead, and then add some documentation in our "testcase cookbook"
wiki page about this routine.
Thanks, Pierre-Marie.
--
Joel
next prev parent reply other threads:[~2015-03-17 20:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 11:55 Pierre-Marie de Rodat
2015-03-17 20:08 ` Joel Brobecker [this message]
2015-03-18 9:45 ` Pedro Alves
2015-03-18 14:12 ` Joel Brobecker
2015-03-20 12:18 ` Pierre-Marie de Rodat
2015-03-20 18:00 ` Pedro Alves
2015-04-01 8:50 ` Pierre-Marie de Rodat
2015-04-01 10:26 ` Pedro Alves
2015-04-01 13:08 ` Pierre-Marie de Rodat
2015-07-18 0:35 ` Sergio Durigan Junior
2015-07-20 14:49 ` Pierre-Marie de Rodat
2015-07-20 15:35 ` Sergio Durigan Junior
2015-07-20 22:23 ` Joel Brobecker
2015-07-20 22:42 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150317200809.GD7494@adacore.com \
--to=brobecker@adacore.com \
--cc=derodat@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox