From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76257 invoked by alias); 17 Mar 2015 20:08:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76245 invoked by uid 89); 17 Mar 2015 20:08:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 17 Mar 2015 20:08:11 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6E85C116347; Tue, 17 Mar 2015 16:08:09 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 6RWrL1I80buW; Tue, 17 Mar 2015 16:08:09 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 55F76116342; Tue, 17 Mar 2015 16:08:09 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 090F540EAD; Tue, 17 Mar 2015 16:08:09 -0400 (EDT) Date: Tue, 17 Mar 2015 20:08:00 -0000 From: Joel Brobecker To: Pierre-Marie de Rodat Cc: GDB Patches Subject: Re: [PATCH] Share the "multi_line" helper among all Ada testcases Message-ID: <20150317200809.GD7494@adacore.com> References: <54FEDB92.9060808@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54FEDB92.9060808@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-03/txt/msg00502.txt.bz2 > This patch is a tiny cleanup for the Ada testsuite: it put the > "multi_line" helper (currently defined in 6 testcases) in a common > place: ada.exp. It triggers no regression (tested on x86_64-linux). > > Ok to push? > Thank you in advance, > > gdb/testsuite/ChangeLog: > 2015-03-10 Pierre-Marie de Rodat > > * gdb.ada/complete.exp: Remove "multi_line". > * gdb.ada/info_exc.exp: Remove "multi_line". > * gdb.ada/packed_tagged.exp: Remove "multi_line". > * gdb.ada/ptype_field.exp: Remove "multi_line". > * gdb.ada/sym_print_name.exp: Remove "multi_line". > * gdb.ada/tagged.exp: Remove "multi_line". > * lib/ada.exp: Add the "multi_line" helper. At the time I introduced this function, I thought it should even be in gdb.exp, but others did not agree with its usefulness, which explains why I ended up duplicating it everywhere. Let's do the following: Let's give people a week to comment on this, and if there are no objection, let's put it in ada.exp. If others agree that this should be in gdb.exp, then let's do that instead, and then add some documentation in our "testcase cookbook" wiki page about this routine. Thanks, Pierre-Marie. -- Joel