From: Gary Benson <gbenson@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [pushed] Fix gdb.threads/thread-specific-bp.exp race
Date: Thu, 05 Mar 2015 09:22:00 -0000 [thread overview]
Message-ID: <20150305092249.GA32050@blade.nx> (raw)
In-Reply-To: <1425497614-16522-1-git-send-email-palves@redhat.com>
Pedro Alves wrote:
> Gary stumbled on this:
>
> (gdb) PASS: gdb.threads/thread-specific-bp.exp: all-stop: continue to end
> info threads
> Id Target Id Frame
> * 1 Thread 0x7ffff7fdb700 (LWP 13717) "thread-specific" end () at /home/gary/work/archer/startswith/src/gdb/testsuite/gdb.threads/thread-specific-bp.c:29
> (gdb) FAIL: gdb.threads/thread-specific-bp.exp: all-stop: thread start is gone
> info breakpoint
>
> The problem is that "...archer/startswith/src..." has a "start" in
> it, which matches the too-lax regex in the test.
>
> Rather than tweaking the regex, we can just remove the whole "info
> threads", like we removed similar ones in other files -- GDB
> nowadays does this implicitly already, so things should work without
> it. Thus removing this even improves testing here a bit.
>
> gdb/testsuite/ChangeLog:
> 2015-03-04 Pedro Alves <palves@redhat.com>
>
> * gdb.threads/thread-specific-bp.exp: Delete "info threads" test.
Thanks for fixing this Pedro.
Cheers,
Gary
--
http://gbenson.net/
prev parent reply other threads:[~2015-03-05 9:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 19:33 Pedro Alves
2015-03-05 9:22 ` Gary Benson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150305092249.GA32050@blade.nx \
--to=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox