From: Pedro Alves <palves@redhat.com>
To: gdb-patches@sourceware.org
Subject: [pushed] Fix gdb.threads/thread-specific-bp.exp race
Date: Wed, 04 Mar 2015 19:33:00 -0000 [thread overview]
Message-ID: <1425497614-16522-1-git-send-email-palves@redhat.com> (raw)
Gary stumbled on this:
(gdb) PASS: gdb.threads/thread-specific-bp.exp: all-stop: continue to end
info threads
Id Target Id Frame
* 1 Thread 0x7ffff7fdb700 (LWP 13717) "thread-specific" end () at /home/gary/work/archer/startswith/src/gdb/testsuite/gdb.threads/thread-specific-bp.c:29
(gdb) FAIL: gdb.threads/thread-specific-bp.exp: all-stop: thread start is gone
info breakpoint
The problem is that "...archer/startswith/src..." has a "start" in it,
which matches the too-lax regex in the test.
Rather than tweaking the regex, we can just remove the whole "info
threads", like we removed similar ones in other files -- GDB nowadays
does this implicitly already, so things should work without it. Thus
removing this even improves testing here a bit.
gdb/testsuite/ChangeLog:
2015-03-04 Pedro Alves <palves@redhat.com>
* gdb.threads/thread-specific-bp.exp: Delete "info threads" test.
---
gdb/testsuite/ChangeLog | 4 ++++
gdb/testsuite/gdb.threads/thread-specific-bp.exp | 13 -------------
2 files changed, 4 insertions(+), 13 deletions(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 3f41178..6f97eda 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2015-03-04 Pedro Alves <palves@redhat.com>
+
+ * gdb.threads/thread-specific-bp.exp: Delete "info threads" test.
+
2015-03-04 Mark Kettenis <kettenis@gnu.org>
* gdb.base/foll-fork.exp: Enable on *-*-openbsd*.
diff --git a/gdb/testsuite/gdb.threads/thread-specific-bp.exp b/gdb/testsuite/gdb.threads/thread-specific-bp.exp
index e167564..c4d8286 100644
--- a/gdb/testsuite/gdb.threads/thread-specific-bp.exp
+++ b/gdb/testsuite/gdb.threads/thread-specific-bp.exp
@@ -91,19 +91,6 @@ proc check_thread_specific_breakpoint {mode} {
"Breakpoint .* end .* at .*" \
"continue to end"
- # Force GDB to update the thread list. Otherwise, depending
- # on target, GDB may not realize that the start thread has
- # exited and thus not remove the thread specific breakpoint.
- set test "thread start is gone"
- gdb_test_multiple "info threads" $test {
- -re "\[0-9\]+.*start.*$gdb_prompt $" {
- fail $test
- }
- -re "$gdb_prompt $" {
- pass $test
- }
- }
-
set test "thread-specific breakpoint was deleted"
gdb_test_multiple "info breakpoint" $test {
-re "thread $start_thre\n$gdb_prompt $" {
--
1.9.3
next reply other threads:[~2015-03-04 19:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 19:33 Pedro Alves [this message]
2015-03-05 9:22 ` Gary Benson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425497614-16522-1-git-send-email-palves@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox