From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40051 invoked by alias); 5 Mar 2015 09:22:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39997 invoked by uid 89); 5 Mar 2015 09:22:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 05 Mar 2015 09:22:52 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t259MpBb006116 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 5 Mar 2015 04:22:51 -0500 Received: from blade.nx (ovpn-116-103.ams2.redhat.com [10.36.116.103]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t259Mofh029861; Thu, 5 Mar 2015 04:22:50 -0500 Received: by blade.nx (Postfix, from userid 1000) id 9C2FF265059; Thu, 5 Mar 2015 09:22:49 +0000 (GMT) Date: Thu, 05 Mar 2015 09:22:00 -0000 From: Gary Benson To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [pushed] Fix gdb.threads/thread-specific-bp.exp race Message-ID: <20150305092249.GA32050@blade.nx> References: <1425497614-16522-1-git-send-email-palves@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425497614-16522-1-git-send-email-palves@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00145.txt.bz2 Pedro Alves wrote: > Gary stumbled on this: > > (gdb) PASS: gdb.threads/thread-specific-bp.exp: all-stop: continue to end > info threads > Id Target Id Frame > * 1 Thread 0x7ffff7fdb700 (LWP 13717) "thread-specific" end () at /home/gary/work/archer/startswith/src/gdb/testsuite/gdb.threads/thread-specific-bp.c:29 > (gdb) FAIL: gdb.threads/thread-specific-bp.exp: all-stop: thread start is gone > info breakpoint > > The problem is that "...archer/startswith/src..." has a "start" in > it, which matches the too-lax regex in the test. > > Rather than tweaking the regex, we can just remove the whole "info > threads", like we removed similar ones in other files -- GDB > nowadays does this implicitly already, so things should work without > it. Thus removing this even improves testing here a bit. > > gdb/testsuite/ChangeLog: > 2015-03-04 Pedro Alves > > * gdb.threads/thread-specific-bp.exp: Delete "info threads" test. Thanks for fixing this Pedro. Cheers, Gary -- http://gbenson.net/