From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Wei-cheng Wang <cole945@gmail.com>
Cc: Ulrich Weigand <uweigand@de.ibm.com>,
gdb-patches@sourceware.org,
Joel Brobecker <brobecker@adacore.com>
Subject: Re: Broken build: rs6000-tdep.c: 32-bit host --enable-targets=all --enable-64-bit-bfd [Re: [PATCH 2/3 v4] Process record support for PowerPC]
Date: Sun, 18 Jan 2015 07:01:00 -0000 [thread overview]
Message-ID: <20150118065908.GA12626@host2.jankratochvil.net> (raw)
In-Reply-To: <54BB3AC2.6050507@gmail.com>
On Sun, 18 Jan 2015 05:46:58 +0100, Wei-cheng Wang wrote:
> Here is the fix. Ok to commit?
[...]
> + fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record %08x "
> + "at 0x%lx, 4-%d.\n", insn, (unsigned long) addr, ext);
That AFAIK does not work on 64-bit MS-Windows where CORE_ADDR is 64-bit but
long is 32-bit there.
GDB has paddress(), core_addr_to_string() and hex_string() instead while the
codebase uses these three interchangeably. But the codebase uses even the
%lx+long form.
Jan
next prev parent reply other threads:[~2015-01-18 7:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-06 18:00 [PATCH 2/3 v2] Process record support for PowerPC Wei-cheng Wang
2014-12-08 19:12 ` Ulrich Weigand
2014-12-17 17:07 ` [PATCH 2/3 v3] " Wei-cheng Wang
2014-12-17 18:41 ` Ulrich Weigand
2014-12-25 17:27 ` [PATCH 2/3 v4] " Wei-cheng Wang
2015-01-01 14:19 ` Ulrich Weigand
2015-01-04 16:27 ` Wei-cheng Wang
2015-01-06 12:42 ` Ulrich Weigand
2015-01-17 6:02 ` Wei-cheng Wang
2015-01-17 11:47 ` Ulrich Weigand
2015-01-17 18:53 ` Joel Brobecker
2015-01-17 21:20 ` Broken build: rs6000-tdep.c: 32-bit host --enable-targets=all --enable-64-bit-bfd [Re: [PATCH 2/3 v4] Process record support for PowerPC] Jan Kratochvil
2015-01-18 4:47 ` Wei-cheng Wang
2015-01-18 7:01 ` Jan Kratochvil [this message]
2015-01-18 8:01 ` Wei-cheng Wang
2015-01-19 7:48 ` Joel Brobecker
2015-01-19 16:10 ` [PATCH 2/3 v4] Process record support for PowerPC Wei-cheng Wang
2015-01-19 18:05 ` Ulrich Weigand
2015-01-20 16:03 ` Wei-cheng Wang
2015-01-20 18:14 ` Ulrich Weigand
2015-01-26 17:19 ` Ulrich Weigand
2015-01-26 17:19 ` Wei-cheng Wang
2015-01-26 19:16 ` Doug Evans
2015-01-26 20:29 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150118065908.GA12626@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=brobecker@adacore.com \
--cc=cole945@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox