From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8011 invoked by alias); 18 Jan 2015 07:01:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6597 invoked by uid 89); 18 Jan 2015 07:00:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 18 Jan 2015 06:59:20 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0I6xDSe021583 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 18 Jan 2015 01:59:13 -0500 Received: from host2.jankratochvil.net (ovpn-116-51.ams2.redhat.com [10.36.116.51]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t0I6x9Vj020676 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Sun, 18 Jan 2015 01:59:11 -0500 Date: Sun, 18 Jan 2015 07:01:00 -0000 From: Jan Kratochvil To: Wei-cheng Wang Cc: Ulrich Weigand , gdb-patches@sourceware.org, Joel Brobecker Subject: Re: Broken build: rs6000-tdep.c: 32-bit host --enable-targets=all --enable-64-bit-bfd [Re: [PATCH 2/3 v4] Process record support for PowerPC] Message-ID: <20150118065908.GA12626@host2.jankratochvil.net> References: <201501171146.t0HBktpk008932@d03av02.boulder.ibm.com> <20150117185342.GA10419@adacore.com> <20150117212014.GA32152@host2.jankratochvil.net> <54BB3AC2.6050507@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54BB3AC2.6050507@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00506.txt.bz2 On Sun, 18 Jan 2015 05:46:58 +0100, Wei-cheng Wang wrote: > Here is the fix. Ok to commit? [...] > + fprintf_unfiltered (gdb_stdlog, "Warning: Don't know how to record %08x " > + "at 0x%lx, 4-%d.\n", insn, (unsigned long) addr, ext); That AFAIK does not work on 64-bit MS-Windows where CORE_ADDR is 64-bit but long is 32-bit there. GDB has paddress(), core_addr_to_string() and hex_string() instead while the codebase uses these three interchangeably. But the codebase uses even the %lx+long form. Jan