Re: [RFA 04/12] Update memattr.c help strings

[Pedro Alves <palves@redhat.com>]

On 05/09/2018 09:34 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
>>> add_cmd ("mem", class_vars, delete_mem_command, _("\
>>> Delete memory region.\n\
>>> Arguments are the code numbers of the memory regions to delete.\n\
>>> -Usage: delete mem <code number>...\n\
>>> +Usage: delete mem [CODE]...\n\
>>> Do \"info mem\" to see current list of code numbers."), &deletelist);
>>>
> 
> Pedro> I was surprised and confused with the references to "code" and
> Pedro> "code numbers" here.  These are just the numbers as displayed
> Pedro> in the first column of "info mem", right?  How about changing
> Pedro> the references to "code numbers" and "CODE" above to 
> Pedro> numbers or IDs?  The manuals uses "nums".
> 
> I went with IDs, like:
> 
>       add_cmd ("mem", class_vars, delete_mem_command, _("\
>     Delete memory region.\n\
>     Arguments are the identifiers of the memory regions to delete.\n\
>     Usage: delete mem [ID]...\n\
>     Do \"info mem\" to see current list of IDs."), &deletelist);

Great, thanks.

Thanks,
Pedro Alves