From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96403 invoked by alias); 24 May 2018 16:54:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 96391 invoked by uid 89); 24 May 2018 16:54:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 24 May 2018 16:54:48 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B76827D65F; Thu, 24 May 2018 16:54:46 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2B9EA2166BB2; Thu, 24 May 2018 16:54:46 +0000 (UTC) Subject: Re: [RFA 04/12] Update memattr.c help strings To: Tom Tromey References: <20180430143731.30007-1-tom@tromey.com> <20180430143731.30007-5-tom@tromey.com> <4ac45e86-d5c0-6f97-a72c-d6f0f79a3e26@redhat.com> <87h8ng4lg0.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <2014e967-94df-966e-73a7-11d850b4a245@redhat.com> Date: Thu, 24 May 2018 17:53:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <87h8ng4lg0.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-05/txt/msg00652.txt.bz2 On 05/09/2018 09:34 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > >>> add_cmd ("mem", class_vars, delete_mem_command, _("\ >>> Delete memory region.\n\ >>> Arguments are the code numbers of the memory regions to delete.\n\ >>> -Usage: delete mem ...\n\ >>> +Usage: delete mem [CODE]...\n\ >>> Do \"info mem\" to see current list of code numbers."), &deletelist); >>> > > Pedro> I was surprised and confused with the references to "code" and > Pedro> "code numbers" here. These are just the numbers as displayed > Pedro> in the first column of "info mem", right? How about changing > Pedro> the references to "code numbers" and "CODE" above to > Pedro> numbers or IDs? The manuals uses "nums". > > I went with IDs, like: > > add_cmd ("mem", class_vars, delete_mem_command, _("\ > Delete memory region.\n\ > Arguments are the identifiers of the memory regions to delete.\n\ > Usage: delete mem [ID]...\n\ > Do \"info mem\" to see current list of IDs."), &deletelist); Great, thanks. Thanks, Pedro Alves