Re: [RFA 03/12] Update core-related help strings

[Pedro Alves <palves@redhat.com>]

On 05/09/2018 09:31 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
> Pedro> On 04/30/2018 03:37 PM, Tom Tromey wrote:
>>> diff --git a/gdb/gcore.c b/gdb/gcore.c
>>> index 5ff4e6dc77..c53810049c 100644
>>> --- a/gdb/gcore.c
>>> +++ b/gdb/gcore.c
>>> @@ -611,7 +611,8 @@ _initialize_gcore (void)
>>> {
>>> add_com ("generate-core-file", class_files, gcore_command, _("\
>>> Save a core file with the current state of the debugged process.\n\
>>> -Argument is optional filename.  Default filename is 'core.<process_id>'."));
>>> +Usage: generate-core-file [FILENAME]\n\
>>> +Argument is optional filename.  Default filename is 'core.PROCESS_ID'."));
> 
> Pedro> Do the guidelines say anything about this?  I mean, PROCESS_ID is not
> Pedro> user input, so I'm wondering whether it should be all caps, or whether
> Pedro> it was better as it was.
> 
> Pedro> Otherwise looks fine.
> 
> The docs don't say much, but since the PID is a meta-syntactic variable,
> I think this is the way to go.

OK.

Thanks,
Pedro Alves