From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <palves@redhat.com>
Cc: Marcus Shawcroft <marcus.shawcroft@gmail.com>,
Terry Guo <terry.guo@arm.com>,
Marcus Shawcroft <marcus.shawcroft@arm.com>,
lgustavo@codesourcery.com, Yao Qi <yao@codesourcery.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Will Deacon <will.deacon@arm.com>,
peter.maydell@arm.com,
"gareth@blacksphere.co.nz >> Gareth McMullin"
<gareth@blacksphere.co.nz>
Subject: Re: [RFA/commit] arm-tdep.c: Do not single-step after hitting a watchpoint.
Date: Mon, 29 Sep 2014 17:51:00 -0000 [thread overview]
Message-ID: <20140929175151.GC6927@adacore.com> (raw)
In-Reply-To: <541C6860.9070907@redhat.com>
Hello all,
> Hmm. So when the data abort triggers at fault+8, the instruction
> that triggered the abort hasn't actually completed, right? No memory
> has changed yet.
>
> So if nothing does the adjustment, like Gareth found out happens with
> the Black Magic Probe, then we'll resume execution from the
> wrong address/instruction (with the effects of the skipped instructions
> missing, including the memory write...). Did I understand that
> right? (Gareth, is that what you see?)
I have been trying to understand the various contributions, and
I admit I am still not quite sure...
Does it look like the patch I proposed is correct? It seems to be
supported by Terry Guo's experiments as well...
Thanks!
--
Joel
next prev parent reply other threads:[~2014-09-29 17:51 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 13:01 Joel Brobecker
2014-09-16 11:12 ` Yao Qi
2014-09-16 11:59 ` Joel Brobecker
2014-09-16 12:05 ` Luis Machado
2014-09-16 12:48 ` Joel Brobecker
2014-09-16 13:09 ` Luis Machado
2014-09-16 15:21 ` Pedro Alves
2014-09-18 11:40 ` Marcus Shawcroft
2014-09-19 17:31 ` Pedro Alves
2014-09-29 17:51 ` Joel Brobecker [this message]
2014-09-29 17:57 ` Luis Machado
2014-09-29 21:04 ` Pedro Alves
2014-09-30 8:54 ` Will Deacon
2014-09-29 18:23 Peter Maydell
2014-09-29 22:15 ` Pedro Alves
2014-09-29 22:54 ` Peter Maydell
2014-09-30 9:08 ` Pedro Alves
2014-09-30 9:18 ` Will Deacon
2014-09-30 10:07 ` Pedro Alves
2014-09-30 10:18 ` Peter Maydell
2014-09-30 10:38 ` Pedro Alves
2014-09-30 10:01 ` Peter Maydell
2014-09-30 10:34 ` Pedro Alves
2014-09-30 12:54 ` Pedro Alves
2014-09-30 13:50 ` Joel Brobecker
2014-09-30 14:11 ` Pedro Alves
2014-09-30 14:26 ` Joel Brobecker
2014-09-30 14:50 ` Peter Maydell
2014-09-30 8:57 ` Will Deacon
2014-09-30 9:04 ` Will Deacon
2014-09-30 9:14 ` Pedro Alves
2014-09-30 9:24 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140929175151.GC6927@adacore.com \
--to=brobecker@adacore.com \
--cc=gareth@blacksphere.co.nz \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
--cc=marcus.shawcroft@arm.com \
--cc=marcus.shawcroft@gmail.com \
--cc=palves@redhat.com \
--cc=peter.maydell@arm.com \
--cc=terry.guo@arm.com \
--cc=will.deacon@arm.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox