From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15813 invoked by alias); 29 Sep 2014 17:51:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15802 invoked by uid 89); 29 Sep 2014 17:51:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 29 Sep 2014 17:51:55 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id EA3341161B6; Mon, 29 Sep 2014 13:51:52 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id B22uqPtgZSJ8; Mon, 29 Sep 2014 13:51:52 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 72AA0116196; Mon, 29 Sep 2014 13:51:51 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 20880497D8; Mon, 29 Sep 2014 10:51:51 -0700 (PDT) Date: Mon, 29 Sep 2014 17:51:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: Marcus Shawcroft , Terry Guo , Marcus Shawcroft , lgustavo@codesourcery.com, Yao Qi , "gdb-patches@sourceware.org" , Will Deacon , peter.maydell@arm.com, "gareth@blacksphere.co.nz >> Gareth McMullin" Subject: Re: [RFA/commit] arm-tdep.c: Do not single-step after hitting a watchpoint. Message-ID: <20140929175151.GC6927@adacore.com> References: <1410786062-19274-1-git-send-email-brobecker@adacore.com> <87bnqf2578.fsf@codesourcery.com> <20140916115936.GM4871@adacore.com> <5418279A.1040604@codesourcery.com> <20140916124814.GO4871@adacore.com> <54183681.3010504@codesourcery.com> <5418556E.7010502@redhat.com> <541C6860.9070907@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <541C6860.9070907@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-09/txt/msg00843.txt.bz2 Hello all, > Hmm. So when the data abort triggers at fault+8, the instruction > that triggered the abort hasn't actually completed, right? No memory > has changed yet. > > So if nothing does the adjustment, like Gareth found out happens with > the Black Magic Probe, then we'll resume execution from the > wrong address/instruction (with the effects of the skipped instructions > missing, including the memory write...). Did I understand that > right? (Gareth, is that what you see?) I have been trying to understand the various contributions, and I admit I am still not quite sure... Does it look like the patch I proposed is correct? It seems to be supported by Terry Guo's experiments as well... Thanks! -- Joel