* [patch] Fix library-list.dtd -> library-list-svr4.dtd
@ 2014-09-27 18:29 Jan Kratochvil
2014-09-29 15:34 ` Pedro Alves
2014-09-29 16:15 ` Pedro Alves
0 siblings, 2 replies; 4+ messages in thread
From: Jan Kratochvil @ 2014-09-27 18:29 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 514 bytes --]
Hi,
commit 2268b414f486239cbcc0f756f157c3e03599efac
added file "features/library-list-svr4.dtd" but the added code uses
"library-list.dtd" instead.
Curiously after changing for a test s/name/nXme/ in the DTD making the
gdbserver output non-conforming there is no warning or regression seen (tested
gdb.base/shlib-call.exp, using_xfer is still 1). I did not check more why the
DTD conformance verification does not work.
No regressions on {x86_64,x86_64-m32,i686}-fedora21pre-linux-gnu in gdbserver
mode.
Jan
[-- Attachment #2: svr4.patch --]
[-- Type: text/plain, Size: 693 bytes --]
gdb/
2014-09-27 Jan Kratochvil <jan.kratochvil@redhat.com>
* solib-svr4.c (svr4_parse_libraries): Use "library-list-svr4.dtd".
diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c
index 3deef20..978564c 100644
--- a/gdb/solib-svr4.c
+++ b/gdb/solib-svr4.c
@@ -1209,7 +1209,7 @@ svr4_parse_libraries (const char *document, struct svr4_library_list *list)
memset (list, 0, sizeof (*list));
list->tailp = &list->head;
- if (gdb_xml_parse_quick (_("target library list"), "library-list.dtd",
+ if (gdb_xml_parse_quick (_("target library list"), "library-list-svr4.dtd",
svr4_library_list_elements, document, list) == 0)
{
/* Parsed successfully, keep the result. */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] Fix library-list.dtd -> library-list-svr4.dtd
2014-09-27 18:29 [patch] Fix library-list.dtd -> library-list-svr4.dtd Jan Kratochvil
@ 2014-09-29 15:34 ` Pedro Alves
2014-09-29 15:39 ` [commit] " Jan Kratochvil
2014-09-29 16:15 ` Pedro Alves
1 sibling, 1 reply; 4+ messages in thread
From: Pedro Alves @ 2014-09-29 15:34 UTC (permalink / raw)
To: Jan Kratochvil, gdb-patches
On 09/27/2014 07:28 PM, Jan Kratochvil wrote:
> gdb/
> 2014-09-27 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * solib-svr4.c (svr4_parse_libraries): Use "library-list-svr4.dtd".
OK.
Thanks,
Pedro Alves
^ permalink raw reply [flat|nested] 4+ messages in thread
* [commit] [patch] Fix library-list.dtd -> library-list-svr4.dtd
2014-09-29 15:34 ` Pedro Alves
@ 2014-09-29 15:39 ` Jan Kratochvil
0 siblings, 0 replies; 4+ messages in thread
From: Jan Kratochvil @ 2014-09-29 15:39 UTC (permalink / raw)
To: Pedro Alves; +Cc: gdb-patches
On Mon, 29 Sep 2014 17:34:39 +0200, Pedro Alves wrote:
> On 09/27/2014 07:28 PM, Jan Kratochvil wrote:
> > gdb/
> > 2014-09-27 Jan Kratochvil <jan.kratochvil@redhat.com>
> >
> > * solib-svr4.c (svr4_parse_libraries): Use "library-list-svr4.dtd".
>
> OK.
Checked in:
2eca4a8d84ce27d0768702e93b8fca1578f84d06
Jan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] Fix library-list.dtd -> library-list-svr4.dtd
2014-09-27 18:29 [patch] Fix library-list.dtd -> library-list-svr4.dtd Jan Kratochvil
2014-09-29 15:34 ` Pedro Alves
@ 2014-09-29 16:15 ` Pedro Alves
1 sibling, 0 replies; 4+ messages in thread
From: Pedro Alves @ 2014-09-29 16:15 UTC (permalink / raw)
To: Jan Kratochvil, gdb-patches
On 09/27/2014 07:28 PM, Jan Kratochvil wrote:
> I did not check more why the DTD conformance verification does not work.
Oh, the answer here is that expat is not a validating parser.
Thanks,
Pedro Alves
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-09-29 16:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-27 18:29 [patch] Fix library-list.dtd -> library-list-svr4.dtd Jan Kratochvil
2014-09-29 15:34 ` Pedro Alves
2014-09-29 15:39 ` [commit] " Jan Kratochvil
2014-09-29 16:15 ` Pedro Alves
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox