From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Subject: [patch] Fix library-list.dtd -> library-list-svr4.dtd
Date: Sat, 27 Sep 2014 18:29:00 -0000 [thread overview]
Message-ID: <20140927182859.GA21940@host2.jankratochvil.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 514 bytes --]
Hi,
commit 2268b414f486239cbcc0f756f157c3e03599efac
added file "features/library-list-svr4.dtd" but the added code uses
"library-list.dtd" instead.
Curiously after changing for a test s/name/nXme/ in the DTD making the
gdbserver output non-conforming there is no warning or regression seen (tested
gdb.base/shlib-call.exp, using_xfer is still 1). I did not check more why the
DTD conformance verification does not work.
No regressions on {x86_64,x86_64-m32,i686}-fedora21pre-linux-gnu in gdbserver
mode.
Jan
[-- Attachment #2: svr4.patch --]
[-- Type: text/plain, Size: 693 bytes --]
gdb/
2014-09-27 Jan Kratochvil <jan.kratochvil@redhat.com>
* solib-svr4.c (svr4_parse_libraries): Use "library-list-svr4.dtd".
diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c
index 3deef20..978564c 100644
--- a/gdb/solib-svr4.c
+++ b/gdb/solib-svr4.c
@@ -1209,7 +1209,7 @@ svr4_parse_libraries (const char *document, struct svr4_library_list *list)
memset (list, 0, sizeof (*list));
list->tailp = &list->head;
- if (gdb_xml_parse_quick (_("target library list"), "library-list.dtd",
+ if (gdb_xml_parse_quick (_("target library list"), "library-list-svr4.dtd",
svr4_library_list_elements, document, list) == 0)
{
/* Parsed successfully, keep the result. */
next reply other threads:[~2014-09-27 18:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-27 18:29 Jan Kratochvil [this message]
2014-09-29 15:34 ` Pedro Alves
2014-09-29 15:39 ` [commit] " Jan Kratochvil
2014-09-29 16:15 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140927182859.GA21940@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox