From: Gary Benson <gbenson@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org, Doug Evans <dje@google.com>
Subject: Re: [PATCH v8] Clarify GDBSERVER use in linux-waitpid.c
Date: Fri, 12 Sep 2014 11:09:00 -0000 [thread overview]
Message-ID: <20140912110902.GA20231@blade.nx> (raw)
In-Reply-To: <5412C56C.4000606@redhat.com>
Pedro Alves wrote:
> On 09/12/2014 11:03 AM, Gary Benson wrote:
> > Pedro Alves wrote:
> > > Sorry, but now that I see it, IMO the end up resulting code
> > > doesn't really look better than what we already have. :-/
> > > We end up with #ifdef GDBSERVER anyway, so might be best to
> > > either leave this be until we come up with a complete solution.
> >
> > Ok, how about this:
> >
> > This commit makes linux-waitpid.c include common-defs.h. GDB's
> > inclusion of defs.h is removed, but gdbserver's inclusion of
> > server.h remains to support some gdbserver-specific debug code
> > that cannot presently be merged. A new FIXME documents this.
> >
> > gdb/ChangeLog:
> >
> > * nat/linux-waitpid.c: Include common-defs.h.
> > [GDBSERVER]: Add FIXME comment.
> > [!GDBSERVER]: Don't include defs.h or signal.h.
> > (linux_debug) [!GDBSERVER]: Remove empty block.
>
> OK.
Ok, this whole series is pushed now and (barring the comment Doug
wanted changed) complete. Thanks for the help guys!
Cheers,
Gary
--
http://gbenson.net/
next prev parent reply other threads:[~2014-09-12 11:09 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 13:57 [PATCH 0/9 v7] Common code cleanups Gary Benson
2014-08-29 13:51 ` [PATCH 2/9 v7] Introduce target/target.h Gary Benson
2014-09-10 10:17 ` Pedro Alves
2014-08-29 13:51 ` [PATCH 4/9 v7] Introduce target/symbol.h Gary Benson
2014-09-10 11:59 ` Pedro Alves
2014-09-11 10:47 ` Gary Benson
2014-08-29 13:51 ` [PATCH 1/9 v7] Introduce show_debug_regs Gary Benson
2014-09-10 10:09 ` Pedro Alves
2014-08-29 13:51 ` [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid Gary Benson
2014-09-10 10:39 ` Pedro Alves
2014-09-10 17:45 ` Doug Evans
2014-09-11 10:27 ` Gary Benson
2014-09-12 11:53 ` Pedro Alves
2014-09-12 16:53 ` Doug Evans
2014-09-12 17:20 ` Pedro Alves
2014-09-12 17:38 ` Doug Evans
2014-09-12 17:41 ` Pedro Alves
2014-09-12 18:08 ` Doug Evans
2014-09-12 18:19 ` Pedro Alves
2014-09-12 18:29 ` Doug Evans
2014-09-15 10:07 ` Gary Benson
2014-09-15 16:00 ` Doug Evans
2014-09-15 18:34 ` Doug Evans
2014-09-16 9:49 ` Gary Benson
2014-09-16 10:45 ` Pedro Alves
2014-09-16 10:36 ` Pedro Alves
2014-09-16 21:18 ` Doug Evans
2014-09-17 11:30 ` Pedro Alves
2014-09-17 18:20 ` Doug Evans
2014-09-19 15:51 ` Pedro Alves
2014-09-19 20:47 ` Doug Evans
2014-09-16 9:55 ` Pedro Alves
2014-09-12 12:00 ` Pedro Alves
2014-09-12 17:10 ` Doug Evans
2014-08-29 13:52 ` [PATCH 8/9 v7] Remove GDBSERVER uses from i386-dregs.c Gary Benson
2014-09-10 13:15 ` Pedro Alves
2014-08-29 13:52 ` [PATCH 7/9 v7] Remove GDBSERVER uses from linux-btrace.c Gary Benson
2014-09-10 13:12 ` Pedro Alves
2014-08-29 13:59 ` [PATCH 9/9 v7] Remove one GDBSERVER use from linux-waitpid.c Gary Benson
2014-09-10 13:29 ` Pedro Alves
2014-09-12 10:03 ` [PATCH v8] Clarify GDBSERVER use in linux-waitpid.c Gary Benson
2014-09-12 10:05 ` Pedro Alves
2014-09-12 11:09 ` Gary Benson [this message]
2014-08-29 14:03 ` [PATCH 5/9 v7] Introduce common-regcache.h Gary Benson
2014-09-10 13:09 ` Pedro Alves
2014-09-10 18:00 ` Doug Evans
2014-09-11 11:02 ` Gary Benson
2014-09-11 17:12 ` Doug Evans
2014-09-12 9:45 ` Gary Benson
2014-09-12 16:28 ` Doug Evans
2014-08-29 14:46 ` [PATCH 6/9 v7] Include common-defs.h instead of defs.h/server.h in shared code Gary Benson
2014-09-10 13:11 ` Pedro Alves
2014-09-10 22:34 ` [PATCH 0/9 v7] Common code cleanups Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140912110902.GA20231@blade.nx \
--to=gbenson@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox