From: Pedro Alves <palves@redhat.com>
To: Doug Evans <dje@google.com>
Cc: Gary Benson <gbenson@redhat.com>,
gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid
Date: Fri, 19 Sep 2014 15:51:00 -0000 [thread overview]
Message-ID: <541C50DF.6030105@redhat.com> (raw)
In-Reply-To: <CADPb22QXZRr5yMCT7h8ydJKOn6wKUH5sR5DJBC_4imY6a_FGRA@mail.gmail.com>
On 09/17/2014 07:20 PM, Doug Evans wrote:
>>> I thought about target_resume. It was an semi-interesting case
>>> that immediately popped into my head at the time.
>>> And then I tried to think how the typical reader would interpret it.
>>> I'm not a typical reader, but I think(!) people would expect it to be
>>> asynchronous in the sense that the inferior is resumed and
>>> control returns to gdb. IOW target_resume doesn't also wait
>>> for the inferior to stop after it has been resumed.
>>> Therefore I see no need to rename it (say to target_resume_no_wait).
OK. I was reading it like "a convention where all async functions
ended with _async or _no_wait" would be applied throughout. I could
see instead that restricted to cases where we have two variants -- I
guess that's where my understanding was.
> re: "more important things":
> Eh?
I'm sorry about that. I clearly overreacted...
> Characterizing this as spending time on less important things bothers me.
> gdb has several problems I wish people had spent a bit more time on.
> [OTOH, I'm not suggesting spending *too* much time on this.
> That should go without saying though.]
>
>> Please
>> don't take me wrong. I'm in "how to communicate better mode". I would
>> have liked to have been able to reply quicker to these emails, but I
>> just don't know how -- fyi, today's and yesterday's emails on this
>> subject took me a few hours.
>
> If the situation were reversed and I didn't have time at that moment,
> I'd have just said it's an interesting idea but let's table this discussion
> until we can collect more info.
OK. I'll be sure to ask for clarification earlier too, as I seem to
have misunderstood what you were actually suggesting.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2014-09-19 15:51 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 13:57 [PATCH 0/9 v7] Common code cleanups Gary Benson
2014-08-29 13:51 ` [PATCH 4/9 v7] Introduce target/symbol.h Gary Benson
2014-09-10 11:59 ` Pedro Alves
2014-09-11 10:47 ` Gary Benson
2014-08-29 13:51 ` [PATCH 1/9 v7] Introduce show_debug_regs Gary Benson
2014-09-10 10:09 ` Pedro Alves
2014-08-29 13:51 ` [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid Gary Benson
2014-09-10 10:39 ` Pedro Alves
2014-09-10 17:45 ` Doug Evans
2014-09-11 10:27 ` Gary Benson
2014-09-12 11:53 ` Pedro Alves
2014-09-12 16:53 ` Doug Evans
2014-09-12 17:20 ` Pedro Alves
2014-09-12 17:38 ` Doug Evans
2014-09-12 17:41 ` Pedro Alves
2014-09-12 18:08 ` Doug Evans
2014-09-12 18:19 ` Pedro Alves
2014-09-12 18:29 ` Doug Evans
2014-09-15 10:07 ` Gary Benson
2014-09-15 16:00 ` Doug Evans
2014-09-15 18:34 ` Doug Evans
2014-09-16 9:49 ` Gary Benson
2014-09-16 10:45 ` Pedro Alves
2014-09-16 10:36 ` Pedro Alves
2014-09-16 21:18 ` Doug Evans
2014-09-17 11:30 ` Pedro Alves
2014-09-17 18:20 ` Doug Evans
2014-09-19 15:51 ` Pedro Alves [this message]
2014-09-19 20:47 ` Doug Evans
2014-09-16 9:55 ` Pedro Alves
2014-09-12 12:00 ` Pedro Alves
2014-09-12 17:10 ` Doug Evans
2014-08-29 13:51 ` [PATCH 2/9 v7] Introduce target/target.h Gary Benson
2014-09-10 10:17 ` Pedro Alves
2014-08-29 13:52 ` [PATCH 7/9 v7] Remove GDBSERVER uses from linux-btrace.c Gary Benson
2014-09-10 13:12 ` Pedro Alves
2014-08-29 13:52 ` [PATCH 8/9 v7] Remove GDBSERVER uses from i386-dregs.c Gary Benson
2014-09-10 13:15 ` Pedro Alves
2014-08-29 13:59 ` [PATCH 9/9 v7] Remove one GDBSERVER use from linux-waitpid.c Gary Benson
2014-09-10 13:29 ` Pedro Alves
2014-09-12 10:03 ` [PATCH v8] Clarify GDBSERVER use in linux-waitpid.c Gary Benson
2014-09-12 10:05 ` Pedro Alves
2014-09-12 11:09 ` Gary Benson
2014-08-29 14:03 ` [PATCH 5/9 v7] Introduce common-regcache.h Gary Benson
2014-09-10 13:09 ` Pedro Alves
2014-09-10 18:00 ` Doug Evans
2014-09-11 11:02 ` Gary Benson
2014-09-11 17:12 ` Doug Evans
2014-09-12 9:45 ` Gary Benson
2014-09-12 16:28 ` Doug Evans
2014-08-29 14:46 ` [PATCH 6/9 v7] Include common-defs.h instead of defs.h/server.h in shared code Gary Benson
2014-09-10 13:11 ` Pedro Alves
2014-09-10 22:34 ` [PATCH 0/9 v7] Common code cleanups Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541C50DF.6030105@redhat.com \
--to=palves@redhat.com \
--cc=dje@google.com \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox