From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31310 invoked by alias); 12 Sep 2014 11:09:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31253 invoked by uid 89); 12 Sep 2014 11:09:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 12 Sep 2014 11:09:06 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8CB93eT018311 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 12 Sep 2014 07:09:03 -0400 Received: from blade.nx (ovpn-116-128.ams2.redhat.com [10.36.116.128]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8CB92RF001360; Fri, 12 Sep 2014 07:09:03 -0400 Received: by blade.nx (Postfix, from userid 1000) id 31FA32640D5; Fri, 12 Sep 2014 12:09:02 +0100 (BST) Date: Fri, 12 Sep 2014 11:09:00 -0000 From: Gary Benson To: Pedro Alves Cc: gdb-patches@sourceware.org, Doug Evans Subject: Re: [PATCH v8] Clarify GDBSERVER use in linux-waitpid.c Message-ID: <20140912110902.GA20231@blade.nx> References: <5410523B.8020305@redhat.com> <1410516221-19088-1-git-send-email-gbenson@redhat.com> <5412C56C.4000606@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5412C56C.4000606@redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00391.txt.bz2 Pedro Alves wrote: > On 09/12/2014 11:03 AM, Gary Benson wrote: > > Pedro Alves wrote: > > > Sorry, but now that I see it, IMO the end up resulting code > > > doesn't really look better than what we already have. :-/ > > > We end up with #ifdef GDBSERVER anyway, so might be best to > > > either leave this be until we come up with a complete solution. > > > > Ok, how about this: > > > > This commit makes linux-waitpid.c include common-defs.h. GDB's > > inclusion of defs.h is removed, but gdbserver's inclusion of > > server.h remains to support some gdbserver-specific debug code > > that cannot presently be merged. A new FIXME documents this. > > > > gdb/ChangeLog: > > > > * nat/linux-waitpid.c: Include common-defs.h. > > [GDBSERVER]: Add FIXME comment. > > [!GDBSERVER]: Don't include defs.h or signal.h. > > (linux_debug) [!GDBSERVER]: Remove empty block. > > OK. Ok, this whole series is pushed now and (barring the comment Doug wanted changed) complete. Thanks for the help guys! Cheers, Gary -- http://gbenson.net/