From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Doug Evans <dje@google.com>
Cc: Yao Qi <yao@codesourcery.com>, gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [patch+7.8?] Fix --with-babeltrace with gcc-4.9.1
Date: Tue, 12 Aug 2014 20:38:00 -0000 [thread overview]
Message-ID: <20140812203845.GA18456@host2.jankratochvil.net> (raw)
In-Reply-To: <CADPb22S-e=fR9DCHQwMPaoKoTMfjjLk2C5_h3m5VJMBAXEE8Pg@mail.gmail.com>
On Tue, 12 Aug 2014 22:32:55 +0200, Doug Evans wrote:
> E.g., can we just delete "pos" and the function call that initializes it?
>
> struct bt_iter_pos *pos = bt_iter_get_pos (bt_ctf_get_iter (NULL));
I think we cannot and the reason is given in the comment there:
# Append -Werror to CFLAGS so that configure can catch the warning
# "assignment from incompatible pointer type", which is related to
# the babeltrace change from 1.0.3 to 1.1.0. Babeltrace 1.1.0 works
# in GDB, while babeltrace 1.0.3 is broken.
> Or, if for some reason we need to test whether bf_ctf_get_iter exists,
> can we just
> call it and discard the result?
Also not due to the reason above.
Jan
next prev parent reply other threads:[~2014-08-12 20:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 20:38 [patch] " Jan Kratochvil
2014-08-04 23:37 ` Doug Evans
2014-08-06 1:04 ` Yao Qi
2014-08-12 19:22 ` [patch+7.8?] " Jan Kratochvil
2014-08-12 20:33 ` Doug Evans
2014-08-12 20:38 ` Jan Kratochvil [this message]
2014-08-12 21:28 ` Doug Evans
2014-08-13 1:54 ` Yao Qi
2014-08-13 3:05 ` Doug Evans
2014-08-13 9:52 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140812203845.GA18456@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox