From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-114935-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7629 invoked by alias); 12 Aug 2014 20:38:57 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 7594 invoked by uid 89); 12 Aug 2014 20:38:54 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 12 Aug 2014 20:38:53 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7CKcn9c023656	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);	Tue, 12 Aug 2014 16:38:49 -0400
Received: from host2.jankratochvil.net (ovpn-116-19.ams2.redhat.com [10.36.116.19])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7CKckhl031100	(version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO);	Tue, 12 Aug 2014 16:38:48 -0400
Date: Tue, 12 Aug 2014 20:38:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Doug Evans <dje@google.com>
Cc: Yao Qi <yao@codesourcery.com>, gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [patch+7.8?] Fix --with-babeltrace with gcc-4.9.1
Message-ID: <20140812203845.GA18456@host2.jankratochvil.net>
References: <20140804202907.GA2608@host2.jankratochvil.net> <53E17E14.8070104@codesourcery.com> <20140812192204.GA13299@host2.jankratochvil.net> <CADPb22S-e=fR9DCHQwMPaoKoTMfjjLk2C5_h3m5VJMBAXEE8Pg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CADPb22S-e=fR9DCHQwMPaoKoTMfjjLk2C5_h3m5VJMBAXEE8Pg@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-IsSubscribed: yes
X-SW-Source: 2014-08/txt/msg00200.txt.bz2

On Tue, 12 Aug 2014 22:32:55 +0200, Doug Evans wrote:
> E.g., can we just delete "pos" and the function call that initializes it?
> 
> struct bt_iter_pos *pos = bt_iter_get_pos (bt_ctf_get_iter (NULL));

I think we cannot and the reason is given in the comment there:
  # Append -Werror to CFLAGS so that configure can catch the warning
  # "assignment from incompatible pointer type", which is related to
  # the babeltrace change from 1.0.3 to 1.1.0.  Babeltrace 1.1.0 works
  # in GDB, while babeltrace 1.0.3 is broken.


> Or, if for some reason we need to test whether bf_ctf_get_iter exists,
> can we just
> call it and discard the result?

Also not due to the reason above.


Jan