Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: Doug Evans <dje@google.com>, Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [patch+7.8?] Fix --with-babeltrace with gcc-4.9.1
Date: Wed, 13 Aug 2014 01:54:00 -0000	[thread overview]
Message-ID: <53EAC446.5060409@codesourcery.com> (raw)
In-Reply-To: <CADPb22S-e=fR9DCHQwMPaoKoTMfjjLk2C5_h3m5VJMBAXEE8Pg@mail.gmail.com>

On 08/13/2014 04:32 AM, Doug Evans wrote:
> This seems like an excessive amount of code just to test whether a
> library exists.
> Do we really need all of it?

IMO, it's better to keep them.  When I use babeltrace in GDB, I find the
babeltrace APIs are not stable, so I put more code in the configure
test, to cover GDB usages.

> E.g., can we just delete "pos" and the function call that initializes it?
> 
> struct bt_iter_pos *pos = bt_iter_get_pos (bt_ctf_get_iter (NULL));
> 
> Or, if for some reason we need to test whether bf_ctf_get_iter exists,
> can we just
> call it and discard the result?  [And similarly for the rest of the code.]
> None of this code gets run anyways.

As I said above, bt_iter_get_pos and bf_ctf_get_iter are here to test
they still exist in the babeltrace library.  They are in 1.1.0, but I am
worried that they may be changed or renamed in the future.

-- 
Yao (齐尧)


  parent reply	other threads:[~2014-08-13  1:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-04 20:38 [patch] " Jan Kratochvil
2014-08-04 23:37 ` Doug Evans
2014-08-06  1:04 ` Yao Qi
2014-08-12 19:22   ` [patch+7.8?] " Jan Kratochvil
2014-08-12 20:33     ` Doug Evans
2014-08-12 20:38       ` Jan Kratochvil
2014-08-12 21:28         ` Doug Evans
2014-08-13  1:54       ` Yao Qi [this message]
2014-08-13  3:05         ` Doug Evans
2014-08-13  9:52           ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53EAC446.5060409@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox