From: Gary Benson <gbenson@redhat.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 13/13] Include string.h in common-defs.h
Date: Thu, 07 Aug 2014 08:13:00 -0000 [thread overview]
Message-ID: <20140807081306.GA30420@blade.nx> (raw)
In-Reply-To: <21474.25859.696381.170030@ruffy.mtv.corp.google.com>
Doug Evans wrote:
> Gary Benson writes:
> > This commit includes string.h in common-defs.h and removes all
> > other inclusions.
> >
> > gdb/
> > 2014-07-29 Gary Benson <gbenson@redhat.com>
> >
> > * common/common-defs.h: Include string.h.
> > * aarch64-tdep.c: Do not include string.h.
> > * ada-exp.y: Likewise.
[snip]
> > * xtensa-linux-nat.c: Likewise.
> > [... zoinks! :-) ...]
>
> Fwiw, I'd be happy with replacing all of this with:
>
> * common/common-defs.h: Include string.h.
> All other uses deleted.
>
> [and similarly elsewhere]
>
> No need to go back and change anything though.
> Just my $0.02.
> Some may have a rule to write this as you've done,
> but I think this is another case where we're bogging
> ourselves down in pedantic administrivia.
Ok, I'll do that next time.
Cheers,
Gary
--
http://gbenson.net/
next prev parent reply other threads:[~2014-08-07 8:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 15:11 [PATCH 00/13] Include some headers " Gary Benson
2014-07-29 15:11 ` [PATCH 02/13] Move stdlib.h to common-defs.h Gary Benson
2014-07-29 15:11 ` [PATCH 12/13] Include gdb_assert.h in common-defs.h Gary Benson
2014-07-29 15:11 ` [PATCH 13/13] Include string.h " Gary Benson
2014-08-06 17:25 ` Doug Evans
2014-08-07 8:13 ` Gary Benson [this message]
2014-07-29 15:11 ` [PATCH 03/13] Move stdarg.h to common-defs.h Gary Benson
2014-07-29 15:13 ` [PATCH 04/13] Move stddef.h " Gary Benson
2014-07-29 15:14 ` [PATCH 09/13] Move gdb_locale.h " Gary Benson
2014-07-29 15:18 ` [PATCH 05/13] Move ansidecl.h " Gary Benson
2014-07-29 15:18 ` [PATCH 11/13] Move common-utils.h " Gary Benson
2014-07-29 15:35 ` [PATCH 01/13] Move stdio.h " Gary Benson
2014-07-29 16:02 ` [PATCH 07/13] Move pathmax.h " Gary Benson
2014-07-29 16:08 ` [PATCH 06/13] Move libiberty.h " Gary Benson
2014-07-29 16:22 ` [PATCH 08/13] Move gdb/signals.h " Gary Benson
2014-07-29 16:22 ` [PATCH 10/13] Move ptid.h " Gary Benson
2014-07-30 8:29 ` Gary Benson
2014-07-30 13:35 ` [PATCH 14/13] Move errno.h " Gary Benson
2014-07-31 8:55 ` Tom Tromey
2014-07-31 9:57 ` [PATCH 14/13 v2] " Gary Benson
2014-07-31 10:19 ` Pedro Alves
2014-07-31 15:10 ` Tom Tromey
2014-07-31 10:00 ` [PATCH 14/13] " Pedro Alves
2014-07-31 14:49 ` [PATCH 14/13 v3] " Gary Benson
2014-08-06 17:26 ` [PATCH 00/13] Include some headers in common-defs.h Doug Evans
2014-08-07 8:15 ` Gary Benson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140807081306.GA30420@blade.nx \
--to=gbenson@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox