From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1550 invoked by alias); 7 Aug 2014 08:13:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1538 invoked by uid 89); 7 Aug 2014 08:13:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 07 Aug 2014 08:13:10 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s778D7OF012277 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 7 Aug 2014 04:13:08 -0400 Received: from blade.nx (ovpn-116-43.ams2.redhat.com [10.36.116.43]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s778D7ws005289; Thu, 7 Aug 2014 04:13:07 -0400 Received: by blade.nx (Postfix, from userid 1000) id 7EE382640E0; Thu, 7 Aug 2014 09:13:06 +0100 (BST) Date: Thu, 07 Aug 2014 08:13:00 -0000 From: Gary Benson To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 13/13] Include string.h in common-defs.h Message-ID: <20140807081306.GA30420@blade.nx> References: <1406644635-1011-1-git-send-email-gbenson@redhat.com> <1406644635-1011-14-git-send-email-gbenson@redhat.com> <21474.25859.696381.170030@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21474.25859.696381.170030@ruffy.mtv.corp.google.com> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00130.txt.bz2 Doug Evans wrote: > Gary Benson writes: > > This commit includes string.h in common-defs.h and removes all > > other inclusions. > > > > gdb/ > > 2014-07-29 Gary Benson > > > > * common/common-defs.h: Include string.h. > > * aarch64-tdep.c: Do not include string.h. > > * ada-exp.y: Likewise. [snip] > > * xtensa-linux-nat.c: Likewise. > > [... zoinks! :-) ...] > > Fwiw, I'd be happy with replacing all of this with: > > * common/common-defs.h: Include string.h. > All other uses deleted. > > [and similarly elsewhere] > > No need to go back and change anything though. > Just my $0.02. > Some may have a rule to write this as you've done, > but I think this is another case where we're bogging > ourselves down in pedantic administrivia. Ok, I'll do that next time. Cheers, Gary -- http://gbenson.net/