Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Gary Benson <gbenson@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 00/13] Include some headers in common-defs.h
Date: Tue, 29 Jul 2014 15:11:00 -0000	[thread overview]
Message-ID: <1406644635-1011-1-git-send-email-gbenson@redhat.com> (raw)

Hi all,

This series builds on my "config.h rationalization" series that is
currently under review [1].

Each patch adds one #include line to common-defs.h and removes all
other inclusions of that file in all files that include either defs.h
or server.h.  Patches 1-11 deal with files that are already included
by both defs.h and server.h; these patches don't really change
anything about the build.  Patches 12 and 13 add gdb_assert.h and
string.h respectively.  These are included by server.h but not by
defs.h, but both are included in hundreds of files so I think they
are good candidates for global inclusion.

There are three more files that are included by both defs.h and
server.h that I have not dealt with in this series.  errno.h and
alloca.h are both handled completely differently by defs.h and
server.h: moving these headers to common-defs.h should be done, but
will require merging the configury.  The final file, print-utils.h,
is included indirectly by both defs.h and server.h but cannot be
merged without some of the "Common code cleanups" series [2].  That
needs some rewriting, so I'll add that to common-defs.h as part of
the next version of that series.

Is this ok to commit?

Thanks,
Gary

--
[1] https://sourceware.org/ml/gdb-patches/2014-07/msg00670.html
[2] https://sourceware.org/ml/gdb-patches/2014-07/msg00427.html


             reply	other threads:[~2014-07-29 15:11 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-29 15:11 Gary Benson [this message]
2014-07-29 15:11 ` [PATCH 03/13] Move stdarg.h to common-defs.h Gary Benson
2014-07-29 15:11 ` [PATCH 13/13] Include string.h in common-defs.h Gary Benson
2014-08-06 17:25   ` Doug Evans
2014-08-07  8:13     ` Gary Benson
2014-07-29 15:11 ` [PATCH 12/13] Include gdb_assert.h " Gary Benson
2014-07-29 15:11 ` [PATCH 02/13] Move stdlib.h to common-defs.h Gary Benson
2014-07-29 15:13 ` [PATCH 04/13] Move stddef.h " Gary Benson
2014-07-29 15:14 ` [PATCH 09/13] Move gdb_locale.h " Gary Benson
2014-07-29 15:18 ` [PATCH 11/13] Move common-utils.h " Gary Benson
2014-07-29 15:18 ` [PATCH 05/13] Move ansidecl.h " Gary Benson
2014-07-29 15:35 ` [PATCH 01/13] Move stdio.h " Gary Benson
2014-07-29 16:02 ` [PATCH 07/13] Move pathmax.h " Gary Benson
2014-07-29 16:08 ` [PATCH 06/13] Move libiberty.h " Gary Benson
2014-07-29 16:22 ` [PATCH 10/13] Move ptid.h " Gary Benson
2014-07-30  8:29   ` Gary Benson
2014-07-29 16:22 ` [PATCH 08/13] Move gdb/signals.h " Gary Benson
2014-07-30 13:35 ` [PATCH 14/13] Move errno.h " Gary Benson
2014-07-31  8:55   ` Tom Tromey
2014-07-31  9:57     ` [PATCH 14/13 v2] " Gary Benson
2014-07-31 10:19       ` Pedro Alves
2014-07-31 15:10         ` Tom Tromey
2014-07-31 10:00     ` [PATCH 14/13] " Pedro Alves
2014-07-31 14:49       ` [PATCH 14/13 v3] " Gary Benson
2014-08-06 17:26 ` [PATCH 00/13] Include some headers in common-defs.h Doug Evans
2014-08-07  8:15   ` Gary Benson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406644635-1011-1-git-send-email-gbenson@redhat.com \
    --to=gbenson@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox