From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31032 invoked by alias); 29 Jul 2014 15:11:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8320 invoked by uid 89); 29 Jul 2014 14:37:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 29 Jul 2014 14:37:19 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6TEbIEf025329 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 29 Jul 2014 10:37:18 -0400 Received: from blade.nx (ovpn-116-90.ams2.redhat.com [10.36.116.90]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6TEbHUJ017895 for ; Tue, 29 Jul 2014 10:37:18 -0400 Received: from blade.nx (localhost [127.0.0.1]) by blade.nx (Postfix) with ESMTP id 1DD4E2640D5 for ; Tue, 29 Jul 2014 15:37:17 +0100 (BST) From: Gary Benson To: gdb-patches@sourceware.org Subject: [PATCH 00/13] Include some headers in common-defs.h Date: Tue, 29 Jul 2014 15:11:00 -0000 Message-Id: <1406644635-1011-1-git-send-email-gbenson@redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00737.txt.bz2 Hi all, This series builds on my "config.h rationalization" series that is currently under review [1]. Each patch adds one #include line to common-defs.h and removes all other inclusions of that file in all files that include either defs.h or server.h. Patches 1-11 deal with files that are already included by both defs.h and server.h; these patches don't really change anything about the build. Patches 12 and 13 add gdb_assert.h and string.h respectively. These are included by server.h but not by defs.h, but both are included in hundreds of files so I think they are good candidates for global inclusion. There are three more files that are included by both defs.h and server.h that I have not dealt with in this series. errno.h and alloca.h are both handled completely differently by defs.h and server.h: moving these headers to common-defs.h should be done, but will require merging the configury. The final file, print-utils.h, is included indirectly by both defs.h and server.h but cannot be merged without some of the "Common code cleanups" series [2]. That needs some rewriting, so I'll add that to common-defs.h as part of the next version of that series. Is this ok to commit? Thanks, Gary -- [1] https://sourceware.org/ml/gdb-patches/2014-07/msg00670.html [2] https://sourceware.org/ml/gdb-patches/2014-07/msg00427.html