Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Gary Benson <gbenson@redhat.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 06/15] Remove simple GDBSERVER uses from common, nat and target
Date: Tue, 15 Jul 2014 15:42:00 -0000	[thread overview]
Message-ID: <20140715153749.GA24522@blade.nx> (raw)
In-Reply-To: <21444.9684.974497.695609@ruffy.mtv.corp.google.com>

Doug Evans wrote:
> Gary Benson writes:
> > This removes various simple GDBSERVER uses from common, nat and
> > target.  The simple uses are just cases where the code includes defs.h
> > or server.h depending on GDBSERVER.  Instead, now the files include
> > the headers that they require.  Unfortunately we still need to check
> > GDBSERVER for some files to decide which gnulib config header to
> > import, but this is a step in the right direction.
[snip]
> 
> LGTM, one nit:
> 
> How about
> 
> #include "config.h"
> 
> instead of
> 
> #include <config.h>
> ?

I've no objection with this, I'll make the change.

Thanks,
Gary

-- 
http://gbenson.net/


  reply	other threads:[~2014-07-15 15:37 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-09 11:25 [PATCH 00/15] Common code cleanups Gary Benson
2014-07-09 10:38 ` [PATCH 04/15] Introduce common-types.h Gary Benson
2014-07-09 10:38 ` [PATCH 02/15] Remove some GDBSERVER checks from linux-ptrace Gary Benson
2014-07-09 17:27   ` Breazeal, Don
2014-07-09 18:20     ` Gary Benson
2014-07-09 18:23       ` Breazeal, Don
2014-07-11 19:30   ` Doug Evans
2014-07-15 12:30     ` Gary Benson
2014-07-09 10:38 ` [PATCH 03/15] Make gdbserver CORE_ADDR unsigned Gary Benson
2014-07-11 19:34   ` Doug Evans
2014-07-09 10:38 ` [PATCH 01/15] Introduce common/errors.h Gary Benson
2014-07-09 10:39 ` [PATCH 15/15] Finally remove GDBSERVER (mostly) from linux-btrace.c Gary Benson
2014-07-09 10:39 ` [PATCH 09/15] Mostly remove GDBSERVER from linux-waitpid.c Gary Benson
2014-07-14 19:01   ` Doug Evans
2014-07-15 17:17     ` Gary Benson
2014-07-09 10:39 ` [PATCH 11/15] More target unification Gary Benson
2014-07-14 19:17   ` Doug Evans
2014-07-16 10:23     ` Gary Benson
2014-07-09 10:41 ` [PATCH 10/15] Add target/target.h Gary Benson
2014-07-10 17:50   ` Tom Tromey
2014-07-16  8:55     ` Gary Benson
2014-07-17 16:49       ` Tom Tromey
2014-07-09 10:41 ` [PATCH 08/15] Make btrace-common.h not use GDBSERVER Gary Benson
2014-07-14 18:59   ` Doug Evans
2014-07-09 10:41 ` [PATCH 07/15] Remove GDBSERVER use from nat/i386-dregs.c Gary Benson
2014-07-10 17:49   ` Tom Tromey
2014-07-11 12:57     ` Gary Benson
2014-07-11 15:38       ` Tom Tromey
2014-07-14  8:36         ` Gary Benson
2014-07-14 18:49   ` Doug Evans
2014-07-09 10:41 ` [PATCH 06/15] Remove simple GDBSERVER uses from common, nat and target Gary Benson
2014-07-14 18:49   ` Doug Evans
2014-07-15 15:42     ` Gary Benson [this message]
2014-07-09 10:52 ` [PATCH 05/15] Introduce and use debug_printf and debug_vprintf Gary Benson
2014-07-11 19:57   ` Doug Evans
2014-07-15 15:21     ` Gary Benson
2014-07-09 11:25 ` [PATCH 12/15] Add target/symbol.h, update users Gary Benson
2014-07-10 17:52   ` Tom Tromey
2014-07-10 18:55     ` Doug Evans
2014-07-10 19:16       ` Tom Tromey
2014-07-11 13:25         ` Gary Benson
2014-07-11 19:29           ` Doug Evans
2014-07-16 13:01             ` Gary Benson
2014-07-17 18:14               ` Tom Tromey
2014-07-16 10:38     ` Gary Benson
2014-07-17 16:50       ` Tom Tromey
2014-07-09 11:25 ` [PATCH 14/15] Introduce common_get_thread_regcache Gary Benson
2014-07-14 20:32   ` Doug Evans
2014-07-16 13:32     ` Gary Benson
2014-07-09 11:32 ` [PATCH 13/15] Finally remove GDBSERVER (mostly) from agent.c Gary Benson
2014-07-14 19:35   ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140715153749.GA24522@blade.nx \
    --to=gbenson@redhat.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox