Re: [PATCH 02/15] Remove some GDBSERVER checks from linux-ptrace

[Gary Benson <gbenson@redhat.com>]

Doug Evans wrote:
> Gary Benson writes:
>  > @@ -433,18 +435,7 @@ linux_test_for_tracefork (int child_pid)
>  >  
>  >  	  /* We got the PID from the grandchild, which means fork
>  >  	     tracing is supported.  */
>  > -#ifdef GDBSERVER
>  > -	  /* Do not enable all the options for now since gdbserver does not
>  > -	     properly support them.  This restriction will be lifted when
>  > -	     gdbserver is augmented to support them.  */
>  > -	  current_ptrace_options |= PTRACE_O_TRACECLONE;
>  > -#else
>  > -	  current_ptrace_options |= PTRACE_O_TRACEFORK | PTRACE_O_TRACEVFORK
>  > -	    | PTRACE_O_TRACECLONE | PTRACE_O_TRACEEXEC;
>  > -
>  > -	  /* Do not enable PTRACE_O_TRACEEXIT until GDB is more prepared to
>  > -	     support read-only process state.  */
>  > -#endif
>  > +	  current_ptrace_options |= PTRACE_O_TRACECLONE | additional_flags;
>  >  
>  >  	  /* Do some cleanup and kill the grandchild.  */
>  >  	  my_waitpid (second_pid, &second_status, 0);
> 
> I can't tell if the PTRACE_O_TRACEEXIT comment was accidentally or
> intentionally dropped.  I'm not sure it's important enough to keep,
> but it would be good to verify its deletion was intentional.

I don't know, so unless Tom has any objections I will reinstate
the comment before the call to linux_ptrace_set_additional_flags
in linux-nat.c.

Thanks,
Gary

-- 
http://gbenson.net/