From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9830 invoked by alias); 15 Jul 2014 12:25:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9407 invoked by uid 89); 15 Jul 2014 12:25:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 15 Jul 2014 12:24:59 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6FCOvXf023120 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Jul 2014 08:24:57 -0400 Received: from blade.nx (ovpn-116-92.ams2.redhat.com [10.36.116.92]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6FCOuxQ004855; Tue, 15 Jul 2014 08:24:57 -0400 Received: by blade.nx (Postfix, from userid 1000) id E86A62640C7; Tue, 15 Jul 2014 13:24:55 +0100 (BST) Date: Tue, 15 Jul 2014 12:30:00 -0000 From: Gary Benson To: Doug Evans Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH 02/15] Remove some GDBSERVER checks from linux-ptrace Message-ID: <20140715122455.GB24939@blade.nx> References: <1404902255-11101-1-git-send-email-gbenson@redhat.com> <1404902255-11101-3-git-send-email-gbenson@redhat.com> <21440.15097.640934.811897@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21440.15097.640934.811897@ruffy.mtv.corp.google.com> X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00372.txt.bz2 Doug Evans wrote: > Gary Benson writes: > > @@ -433,18 +435,7 @@ linux_test_for_tracefork (int child_pid) > > > > /* We got the PID from the grandchild, which means fork > > tracing is supported. */ > > -#ifdef GDBSERVER > > - /* Do not enable all the options for now since gdbserver does not > > - properly support them. This restriction will be lifted when > > - gdbserver is augmented to support them. */ > > - current_ptrace_options |= PTRACE_O_TRACECLONE; > > -#else > > - current_ptrace_options |= PTRACE_O_TRACEFORK | PTRACE_O_TRACEVFORK > > - | PTRACE_O_TRACECLONE | PTRACE_O_TRACEEXEC; > > - > > - /* Do not enable PTRACE_O_TRACEEXIT until GDB is more prepared to > > - support read-only process state. */ > > -#endif > > + current_ptrace_options |= PTRACE_O_TRACECLONE | additional_flags; > > > > /* Do some cleanup and kill the grandchild. */ > > my_waitpid (second_pid, &second_status, 0); > > I can't tell if the PTRACE_O_TRACEEXIT comment was accidentally or > intentionally dropped. I'm not sure it's important enough to keep, > but it would be good to verify its deletion was intentional. I don't know, so unless Tom has any objections I will reinstate the comment before the call to linux_ptrace_set_additional_flags in linux-nat.c. Thanks, Gary -- http://gbenson.net/