From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13967 invoked by alias); 15 Jul 2014 15:37:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13958 invoked by uid 89); 15 Jul 2014 15:37:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 15 Jul 2014 15:37:53 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6FFboPQ012171 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Jul 2014 11:37:50 -0400 Received: from blade.nx (ovpn-116-92.ams2.redhat.com [10.36.116.92]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6FFbnir011058; Tue, 15 Jul 2014 11:37:50 -0400 Received: by blade.nx (Postfix, from userid 1000) id 3D2B12640C7; Tue, 15 Jul 2014 16:37:49 +0100 (BST) Date: Tue, 15 Jul 2014 15:42:00 -0000 From: Gary Benson To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 06/15] Remove simple GDBSERVER uses from common, nat and target Message-ID: <20140715153749.GA24522@blade.nx> References: <1404902255-11101-1-git-send-email-gbenson@redhat.com> <1404902255-11101-7-git-send-email-gbenson@redhat.com> <21444.9684.974497.695609@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21444.9684.974497.695609@ruffy.mtv.corp.google.com> X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00391.txt.bz2 Doug Evans wrote: > Gary Benson writes: > > This removes various simple GDBSERVER uses from common, nat and > > target. The simple uses are just cases where the code includes defs.h > > or server.h depending on GDBSERVER. Instead, now the files include > > the headers that they require. Unfortunately we still need to check > > GDBSERVER for some files to decide which gnulib config header to > > import, but this is a step in the right direction. [snip] > > LGTM, one nit: > > How about > > #include "config.h" > > instead of > > #include > ? I've no objection with this, I'll make the change. Thanks, Gary -- http://gbenson.net/