[7.8] Suggested fix of --enable-targets=all on 32-bit host

[7.8] Suggested fix of --enable-targets=all on 32-bit host

[Jan Kratochvil]

Hi Joel,

suggesting to backport for 7.8:
	[PATCH] bfd/targets: create elf64 selvecs only if 64-bit bfd support is enabled.
	https://sourceware.org/ml/binutils/2014-06/msg00176.html
	https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=886aba9eff0eba428e634f579e8999b67da01b57

as currently on i686 host (that is without --enable-64-bit-bfd):
	./configure --enable-targets=all;make
will fail with:
	../bfd/.libs/libbfd.a(targets.o):(.rodata+0xb0): undefined reference to `elf64_be_vec'
	../bfd/.libs/libbfd.a(targets.o):(.rodata+0xb4): undefined reference to `elf64_le_vec'
	../bfd/.libs/libbfd.a(targets.o):(.rodata+0xe0): undefined reference to `hppa_elf64_vec'
	../bfd/.libs/libbfd.a(targets.o):(.rodata+0xe4): undefined reference to `hppa_elf64_linux_vec'
	../bfd/.libs/libbfd.a(targets.o):(.rodata+0x164): undefined reference to `k1om_elf64_vec'
	../bfd/.libs/libbfd.a(targets.o):(.rodata+0x168): undefined reference to `k1om_elf64_fbsd_vec'
	../bfd/.libs/libbfd.a(targets.o):(.rodata+0x16c): undefined reference to `l1om_elf64_vec'
	../bfd/.libs/libbfd.a(targets.o):(.rodata+0x170): undefined reference to `l1om_elf64_fbsd_vec'
	collect2: error: ld returned 1 exit status
	Makefile:756: recipe for target 'as-new' failed

It got broken by:
	commit 2f67d686330300d4d27ff99ec47a970d744df8bb
	Author: Alan Modra <amodra@gmail.com>
	Date:   Fri May 2 20:11:49 2014 +0930
	    Sort target vectors to suit renaming
and the 7.8 branch was created before the fix above happened.


Jan

Re: [7.8] Suggested fix of --enable-targets=all on 32-bit host

[Joel Brobecker]

> suggesting to backport for 7.8:
> 	[PATCH] bfd/targets: create elf64 selvecs only if 64-bit bfd support is enabled.
> 	https://sourceware.org/ml/binutils/2014-06/msg00176.html
> 	https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=886aba9eff0eba428e634f579e8999b67da01b57
> 
> as currently on i686 host (that is without --enable-64-bit-bfd):
> 	./configure --enable-targets=all;make
> will fail with:
> 	../bfd/.libs/libbfd.a(targets.o):(.rodata+0xb0): undefined reference to `elf64_be_vec'
> 	../bfd/.libs/libbfd.a(targets.o):(.rodata+0xb4): undefined reference to `elf64_le_vec'
> 	../bfd/.libs/libbfd.a(targets.o):(.rodata+0xe0): undefined reference to `hppa_elf64_vec'
> 	../bfd/.libs/libbfd.a(targets.o):(.rodata+0xe4): undefined reference to `hppa_elf64_linux_vec'
> 	../bfd/.libs/libbfd.a(targets.o):(.rodata+0x164): undefined reference to `k1om_elf64_vec'
> 	../bfd/.libs/libbfd.a(targets.o):(.rodata+0x168): undefined reference to `k1om_elf64_fbsd_vec'
> 	../bfd/.libs/libbfd.a(targets.o):(.rodata+0x16c): undefined reference to `l1om_elf64_vec'
> 	../bfd/.libs/libbfd.a(targets.o):(.rodata+0x170): undefined reference to `l1om_elf64_fbsd_vec'
> 	collect2: error: ld returned 1 exit status
> 	Makefile:756: recipe for target 'as-new' failed
> 
> It got broken by:
> 	commit 2f67d686330300d4d27ff99ec47a970d744df8bb
> 	Author: Alan Modra <amodra@gmail.com>
> 	Date:   Fri May 2 20:11:49 2014 +0930
> 	    Sort target vectors to suit renaming
> and the 7.8 branch was created before the fix above happened.

I agree. Would you mind backporting, or would you like me to?

Thanks, Jan.
-- 
Joel

Re: [7.8] Suggested fix of --enable-targets=all on 32-bit host

[Jan Kratochvil]

On Tue, 24 Jun 2014 16:37:59 +0200, Joel Brobecker wrote:
> I agree. Would you mind backporting, or would you like me to?

I am not sure about the Author field and ChangeLogs etc., better if you can do
it as the 7.8 branch owner.


Regards,
Jan

Re: [7.8] Suggested fix of --enable-targets=all on 32-bit host

[Joel Brobecker]

> I am not sure about the Author field and ChangeLogs etc., better if you can do
> it as the 7.8 branch owner.

I did a git-cherry-pick which preserves everything, then pushed.

Thanks,
-- 
Joel