Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [7.8] Suggested fix of --enable-targets=all on 32-bit host
Date: Tue, 24 Jun 2014 14:38:00 -0000	[thread overview]
Message-ID: <20140624143759.GG5281@adacore.com> (raw)
In-Reply-To: <20140624142554.GA6971@host2.jankratochvil.net>

> suggesting to backport for 7.8:
> 	[PATCH] bfd/targets: create elf64 selvecs only if 64-bit bfd support is enabled.
> 	https://sourceware.org/ml/binutils/2014-06/msg00176.html
> 	https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=886aba9eff0eba428e634f579e8999b67da01b57
> 
> as currently on i686 host (that is without --enable-64-bit-bfd):
> 	./configure --enable-targets=all;make
> will fail with:
> 	../bfd/.libs/libbfd.a(targets.o):(.rodata+0xb0): undefined reference to `elf64_be_vec'
> 	../bfd/.libs/libbfd.a(targets.o):(.rodata+0xb4): undefined reference to `elf64_le_vec'
> 	../bfd/.libs/libbfd.a(targets.o):(.rodata+0xe0): undefined reference to `hppa_elf64_vec'
> 	../bfd/.libs/libbfd.a(targets.o):(.rodata+0xe4): undefined reference to `hppa_elf64_linux_vec'
> 	../bfd/.libs/libbfd.a(targets.o):(.rodata+0x164): undefined reference to `k1om_elf64_vec'
> 	../bfd/.libs/libbfd.a(targets.o):(.rodata+0x168): undefined reference to `k1om_elf64_fbsd_vec'
> 	../bfd/.libs/libbfd.a(targets.o):(.rodata+0x16c): undefined reference to `l1om_elf64_vec'
> 	../bfd/.libs/libbfd.a(targets.o):(.rodata+0x170): undefined reference to `l1om_elf64_fbsd_vec'
> 	collect2: error: ld returned 1 exit status
> 	Makefile:756: recipe for target 'as-new' failed
> 
> It got broken by:
> 	commit 2f67d686330300d4d27ff99ec47a970d744df8bb
> 	Author: Alan Modra <amodra@gmail.com>
> 	Date:   Fri May 2 20:11:49 2014 +0930
> 	    Sort target vectors to suit renaming
> and the 7.8 branch was created before the fix above happened.

I agree. Would you mind backporting, or would you like me to?

Thanks, Jan.
-- 
Joel


  reply	other threads:[~2014-06-24 14:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-24 14:26 Jan Kratochvil
2014-06-24 14:38 ` Joel Brobecker [this message]
2014-06-24 14:42   ` Jan Kratochvil
2014-06-24 15:12     ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140624143759.GG5281@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox