Re: [PATCH 2/2] handle VLA in a struct or union

[Joel Brobecker <brobecker@adacore.com>]

Hey Tom,

> Joel> Perhaps we might think of having a new value_from_contents_and_address
> Joel> that produces the value without resolving the type? If Ada is the only
> Joel> user, as it would be, we could possibly put implement that in ada-lang,
> Joel> I think. Kind of ugly, but this would be medium-term only, since we are
> Joel> slowly trying to get rid of the GNAT encodings.
> 
> I put it in value.c, since I generally like to keep the whole module
> together, having been bitten before by code living in the wrong spot.
> I don't really care much though, in case you do.

Great minds think alike. I was offering alternatives in case people
don't want to keep stuff that is not necessarily specific to Ada
but only used by Ada in the common area. But that would usually be
nonsense to me, since that encourages proliferation of the same code
at multiple locations. But sometimes it's only a bandaid and we don't
want to encourage the use of that code, so keeping it close the few
spots where it is still necessary might make better sense.

I can't remember. Is there a dash in "overthinking"? :-)

> Here's the updated patch, which I think addresses all review comments.

I'll try to review the patch again, but you should feel free to
push it anytime you're ready. I am fairly busy at the moment :-(.

Thanks, Tom!
-- 
Joel