From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12309 invoked by alias); 21 May 2014 18:24:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12277 invoked by uid 89); 21 May 2014 18:24:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 21 May 2014 18:24:13 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B89C51160E7; Wed, 21 May 2014 14:24:11 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id lea6UWlaLqs0; Wed, 21 May 2014 14:24:11 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 87EC91160D9; Wed, 21 May 2014 14:24:11 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 3C4CB40FDB; Wed, 21 May 2014 11:24:11 -0700 (PDT) Date: Wed, 21 May 2014 18:24:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] handle VLA in a struct or union Message-ID: <20140521182411.GM22822@adacore.com> References: <1399574816-12845-1-git-send-email-tromey@redhat.com> <1399574816-12845-3-git-send-email-tromey@redhat.com> <20140508210914.GE4063@adacore.com> <87lhucuf98.fsf@fleche.redhat.com> <20140508223853.GF4063@adacore.com> <20140509155726.GG4063@adacore.com> <87fvk3kpng.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87fvk3kpng.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-05/txt/msg00504.txt.bz2 Hey Tom, > Joel> Perhaps we might think of having a new value_from_contents_and_address > Joel> that produces the value without resolving the type? If Ada is the only > Joel> user, as it would be, we could possibly put implement that in ada-lang, > Joel> I think. Kind of ugly, but this would be medium-term only, since we are > Joel> slowly trying to get rid of the GNAT encodings. > > I put it in value.c, since I generally like to keep the whole module > together, having been bitten before by code living in the wrong spot. > I don't really care much though, in case you do. Great minds think alike. I was offering alternatives in case people don't want to keep stuff that is not necessarily specific to Ada but only used by Ada in the common area. But that would usually be nonsense to me, since that encourages proliferation of the same code at multiple locations. But sometimes it's only a bandaid and we don't want to encourage the use of that code, so keeping it close the few spots where it is still necessary might make better sense. I can't remember. Is there a dash in "overthinking"? :-) > Here's the updated patch, which I think addresses all review comments. I'll try to review the patch again, but you should feel free to push it anytime you're ready. I am fairly busy at the moment :-(. Thanks, Tom! -- Joel