From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] handle VLA in a struct or union
Date: Thu, 08 May 2014 22:38:00 -0000 [thread overview]
Message-ID: <20140508223853.GF4063@adacore.com> (raw)
In-Reply-To: <87lhucuf98.fsf@fleche.redhat.com>
> Joel> I think I need to review that code, as I do that a litte little
> Joel> later in the function again. I'll send another update when I have
> Joel> more info on this.
>
> I will try to look at it again tomorrow, don't spend too much effort on
> it.
I think the call to value_from_contents_and_address with the
partially constructed type is borderline, to say the least.
So I think it's worth me looking at it anyways.
So far, I've tried to build the dval using the original type,
but that doesn't seem to be good enough. That's all I could do today,
but I will have another look at it tomorrow.
--
Joel
next prev parent reply other threads:[~2014-05-08 22:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 18:47 [PATCH 0/2] " Tom Tromey
2014-05-08 18:47 ` [PATCH 2/2] handle " Tom Tromey
2014-05-08 19:01 ` pinskia
2014-05-08 19:07 ` Tom Tromey
2014-05-08 20:30 ` Philippe Waroquiers
2014-05-08 21:32 ` Tom Tromey
2014-05-08 21:09 ` Joel Brobecker
2014-05-08 21:33 ` Tom Tromey
2014-05-08 22:38 ` Joel Brobecker [this message]
2014-05-09 15:57 ` Joel Brobecker
2014-05-21 17:28 ` Tom Tromey
2014-05-21 18:24 ` Joel Brobecker
2014-05-21 22:02 ` Joel Brobecker
2014-05-21 22:28 ` Tom Tromey
2014-06-04 20:27 ` Tom Tromey
2014-05-09 8:05 ` Agovic, Sanimir
2014-05-09 21:08 ` Tom Tromey
2014-05-12 15:37 ` Agovic, Sanimir
2014-05-12 17:00 ` Tom Tromey
2014-05-13 7:53 ` Agovic, Sanimir
2014-05-08 18:47 ` [PATCH 1/2] minor cleanups in is_dynamic_type Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140508223853.GF4063@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox