From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17369 invoked by alias); 8 May 2014 22:38:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17351 invoked by uid 89); 8 May 2014 22:38:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 08 May 2014 22:38:56 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 563401160CD; Thu, 8 May 2014 18:38:54 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id n4mU5h0U8M+L; Thu, 8 May 2014 18:38:54 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 2EA901160CA; Thu, 8 May 2014 18:38:54 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id DEA3AE081D; Thu, 8 May 2014 15:38:53 -0700 (PDT) Date: Thu, 08 May 2014 22:38:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] handle VLA in a struct or union Message-ID: <20140508223853.GF4063@adacore.com> References: <1399574816-12845-1-git-send-email-tromey@redhat.com> <1399574816-12845-3-git-send-email-tromey@redhat.com> <20140508210914.GE4063@adacore.com> <87lhucuf98.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lhucuf98.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-05/txt/msg00104.txt.bz2 > Joel> I think I need to review that code, as I do that a litte little > Joel> later in the function again. I'll send another update when I have > Joel> more info on this. > > I will try to look at it again tomorrow, don't spend too much effort on > it. I think the call to value_from_contents_and_address with the partially constructed type is borderline, to say the least. So I think it's worth me looking at it anyways. So far, I've tried to build the dval using the original type, but that doesn't seem to be good enough. That's all I could do today, but I will have another look at it tomorrow. -- Joel