From: Gary Benson <gbenson@redhat.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: Paul_Koning@Dell.com, dje@google.com, gdb-patches@sourceware.org,
tromey@redhat.com
Subject: Re: [PATCH] Prompt user to report bugs
Date: Thu, 15 May 2014 11:38:00 -0000 [thread overview]
Message-ID: <20140515113754.GA13323@blade.nx> (raw)
In-Reply-To: <01d401cf7025$7f3f4ef0$7dbdecd0$@muller@ics-cnrs.unistra.fr>
Pierre Muller wrote:
> so why not simply use
>
> + fputs_unfiltered (_("\nThis is a bug, please report it"), gdb_stderr);
> + if (REPORT_BUGS_TO[0])
> + {
> + fputs_unfiltered (_(". For instructions, see:\n"), gdb_stderr);
> + fprintf_unfiltered (gdb_stderr, _(REPORT_BUGS_TO));
> + }
> + fputs_unfiltered (".\n\n", gdb_stderr);
>
> To allow for possible localization of the URL page?
Did you mean:
> + fprintf_unfiltered (gdb_stderr, "%s.", _(REPORT_BUGS_TO));
^^^^^^
The code you posted would break if _(REPORT_BUGS_TO) had a "%" in it.
Thanks,
Gary
--
http://gbenson.net/
next prev parent reply other threads:[~2014-05-15 11:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 11:07 Gary Benson
2014-05-14 11:22 ` Mark Kettenis
2014-05-14 12:39 ` Yao Qi
2014-05-14 13:15 ` Gary Benson
2014-05-14 20:14 ` Tom Tromey
2014-05-14 21:05 ` Doug Evans
2014-05-14 21:11 ` Paul_Koning
2014-05-14 22:24 ` Doug Evans
2014-05-15 11:39 ` Gary Benson
2014-05-15 17:10 ` Doug Evans
2014-05-15 10:07 ` Pierre Muller
2014-05-15 11:38 ` Gary Benson [this message]
2014-05-27 14:43 ` [COMMITTED PATCH] " Gary Benson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140515113754.GA13323@blade.nx \
--to=gbenson@redhat.com \
--cc=Paul_Koning@Dell.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox