From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25151 invoked by alias); 15 May 2014 11:38:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25139 invoked by uid 89); 15 May 2014 11:38:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 May 2014 11:38:04 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4FBbuDU026287 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 May 2014 07:37:56 -0400 Received: from blade.nx (ovpn-116-48.ams2.redhat.com [10.36.116.48]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4FBbtOd030651; Thu, 15 May 2014 07:37:56 -0400 Received: by blade.nx (Postfix, from userid 1000) id 12C612622C8; Thu, 15 May 2014 12:37:54 +0100 (BST) Date: Thu, 15 May 2014 11:38:00 -0000 From: Gary Benson To: Pierre Muller Cc: Paul_Koning@Dell.com, dje@google.com, gdb-patches@sourceware.org, tromey@redhat.com Subject: Re: [PATCH] Prompt user to report bugs Message-ID: <20140515113754.GA13323@blade.nx> References: <20140514110742.GA25550@blade.nx> <1B70C5D6-D845-4F9A-A874-63DF77FB9030@dell.com> <01d401cf7025$7f3f4ef0$7dbdecd0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <01d401cf7025$7f3f4ef0$7dbdecd0$@muller@ics-cnrs.unistra.fr> X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00223.txt.bz2 Pierre Muller wrote: > so why not simply use > > + fputs_unfiltered (_("\nThis is a bug, please report it"), gdb_stderr); > + if (REPORT_BUGS_TO[0]) > + { > + fputs_unfiltered (_(". For instructions, see:\n"), gdb_stderr); > + fprintf_unfiltered (gdb_stderr, _(REPORT_BUGS_TO)); > + } > + fputs_unfiltered (".\n\n", gdb_stderr); > > To allow for possible localization of the URL page? Did you mean: > + fprintf_unfiltered (gdb_stderr, "%s.", _(REPORT_BUGS_TO)); ^^^^^^ The code you posted would break if _(REPORT_BUGS_TO) had a "%" in it. Thanks, Gary -- http://gbenson.net/