Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: pushed: [RFA/DWARF] constant class of DW_AT_high_pc is offset for version >=4 only.
Date: Wed, 26 Feb 2014 19:45:00 -0000	[thread overview]
Message-ID: <20140226194509.GJ4348@adacore.com> (raw)
In-Reply-To: <20140221184227.GC4720@adacore.com>

> gdb/ChangeLog:
> 
>         * dwarf2read.c (attr_value_as_address): New function.
>         (dwarf2_find_base_address, read_call_site_scope): Use
>         attr_value_as_address in place of DW_ADDR.
>         (dwarf2_get_pc_bounds): Use attr_value_as_address to get
>         the low and high addresses.  Slight rework of the handling
>         of the high pc being a constant form, and limit it to
>         DWARF verson 4 or higher.
>         (dwarf2_record_block_ranges): Likewise.
>         (read_partial_die): Likewise.
>         (new_symbol_full): Use attr_value_as_address in place of DW_ADDR.
> 
> gdb/testsuite/ChangeLog:
> 
>         * gdb.dwarf2/dw2-abs-hi-pc-hello-dbg.S: New file.
>         * gdb.dwarf2/dw2-abs-hi-pc-hello.c: New file.
>         * gdb.dwarf2/dw2-abs-hi-pc-world-dbg.S: New file.
>         * gdb.dwarf2/dw2-abs-hi-pc-world.c: New file.
>         * gdb.dwarf2/dw2-abs-hi-pc.c: New file.
>         * gdb.dwarf2/dw2-abs-hi-pc.exp: New file.

FYI: This patch has now been pushed.  Thanks again to MarkW for all
the insightful comments.

-- 
Joel


      parent reply	other threads:[~2014-02-26 19:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-15 15:40 Joel Brobecker
2014-02-16 19:19 ` Mark Wielaard
2014-02-17  9:19   ` Joel Brobecker
2014-02-18 13:30 ` Joel Brobecker
2014-02-18 16:03   ` Mark Wielaard
2014-02-18 18:49     ` Joel Brobecker
2014-02-18 20:29       ` Doug Evans
2014-02-18 21:52       ` Mark Wielaard
2014-02-19  7:23         ` Joel Brobecker
2014-02-19 13:44           ` Mark Wielaard
2014-02-21 18:42             ` Joel Brobecker
2014-02-26 10:53               ` Mark Wielaard
2014-02-26 19:45               ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140226194509.GJ4348@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox