From: Mark Wielaard <mjw@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/DWARF] constant class of DW_AT_high_pc is offset for version >=4 only.
Date: Wed, 26 Feb 2014 10:53:00 -0000 [thread overview]
Message-ID: <1393412005.8933.139.camel@bordewijk.wildebeest.org> (raw)
In-Reply-To: <20140221184227.GC4720@adacore.com>
On Fri, 2014-02-21 at 19:42 +0100, Joel Brobecker wrote:
> Attached is the latest version of the patch.
>
> I implemented the complaint, and then reverted it, for reasons that
> I explained in the added comment inside the new attr_value_as_address
> function. Basically, I don't want to be doing extra work as well as
> pessimize this function's number of arguments just for a very rare
> case of broken compiler.
Obviously I would like lots of screaming and yelling here (and the
function/argument will probably be inlined anyway, so I don't think the
extra argument passing will actually hurt that much, but that is
speculation). I do understand gdb isn't a DWARF-linter, and how you do
things is more in line with the "be liberal in what you accept"
principle.
No complaints (pun intended) to this patch.
Cheers,
Mark
next prev parent reply other threads:[~2014-02-26 10:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-15 15:40 Joel Brobecker
2014-02-16 19:19 ` Mark Wielaard
2014-02-17 9:19 ` Joel Brobecker
2014-02-18 13:30 ` Joel Brobecker
2014-02-18 16:03 ` Mark Wielaard
2014-02-18 18:49 ` Joel Brobecker
2014-02-18 20:29 ` Doug Evans
2014-02-18 21:52 ` Mark Wielaard
2014-02-19 7:23 ` Joel Brobecker
2014-02-19 13:44 ` Mark Wielaard
2014-02-21 18:42 ` Joel Brobecker
2014-02-26 10:53 ` Mark Wielaard [this message]
2014-02-26 19:45 ` pushed: " Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393412005.8933.139.camel@bordewijk.wildebeest.org \
--to=mjw@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox