From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19424 invoked by alias); 26 Feb 2014 10:53:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19409 invoked by uid 89); 26 Feb 2014 10:53:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Feb 2014 10:53:30 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1QArR28030105 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 26 Feb 2014 05:53:27 -0500 Received: from [10.36.116.104] (ovpn-116-104.ams2.redhat.com [10.36.116.104]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s1QArPvU029135; Wed, 26 Feb 2014 05:53:26 -0500 Subject: Re: [RFA/DWARF] constant class of DW_AT_high_pc is offset for version >=4 only. From: Mark Wielaard To: Joel Brobecker Cc: gdb-patches@sourceware.org In-Reply-To: <20140221184227.GC4720@adacore.com> References: <1392478818-30320-1-git-send-email-brobecker@adacore.com> <20140218133000.GA15835@adacore.com> <1392739369.21975.145.camel@bordewijk.wildebeest.org> <20140218184906.GB15835@adacore.com> <1392760350.21975.200.camel@bordewijk.wildebeest.org> <20140219072317.GA4270@adacore.com> <1392817469.21975.221.camel@bordewijk.wildebeest.org> <20140221184227.GC4720@adacore.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 26 Feb 2014 10:53:00 -0000 Message-ID: <1393412005.8933.139.camel@bordewijk.wildebeest.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-02/txt/msg00772.txt.bz2 On Fri, 2014-02-21 at 19:42 +0100, Joel Brobecker wrote: > Attached is the latest version of the patch. > > I implemented the complaint, and then reverted it, for reasons that > I explained in the added comment inside the new attr_value_as_address > function. Basically, I don't want to be doing extra work as well as > pessimize this function's number of arguments just for a very rare > case of broken compiler. Obviously I would like lots of screaming and yelling here (and the function/argument will probably be inlined anyway, so I don't think the extra argument passing will actually hurt that much, but that is speculation). I do understand gdb isn't a DWARF-linter, and how you do things is more in line with the "be liberal in what you accept" principle. No complaints (pun intended) to this patch. Cheers, Mark