From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5260 invoked by alias); 26 Feb 2014 19:45:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5236 invoked by uid 89); 26 Feb 2014 19:45:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 26 Feb 2014 19:45:14 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 42CEE1166DD for ; Wed, 26 Feb 2014 14:45:12 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id PDtkwJxtWPQz for ; Wed, 26 Feb 2014 14:45:12 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 117741166FC for ; Wed, 26 Feb 2014 14:45:12 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id BAC44E04D4; Wed, 26 Feb 2014 11:45:09 -0800 (PST) Date: Wed, 26 Feb 2014 19:45:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: pushed: [RFA/DWARF] constant class of DW_AT_high_pc is offset for version >=4 only. Message-ID: <20140226194509.GJ4348@adacore.com> References: <1392478818-30320-1-git-send-email-brobecker@adacore.com> <20140218133000.GA15835@adacore.com> <1392739369.21975.145.camel@bordewijk.wildebeest.org> <20140218184906.GB15835@adacore.com> <1392760350.21975.200.camel@bordewijk.wildebeest.org> <20140219072317.GA4270@adacore.com> <1392817469.21975.221.camel@bordewijk.wildebeest.org> <20140221184227.GC4720@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140221184227.GC4720@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-02/txt/msg00806.txt.bz2 > gdb/ChangeLog: > > * dwarf2read.c (attr_value_as_address): New function. > (dwarf2_find_base_address, read_call_site_scope): Use > attr_value_as_address in place of DW_ADDR. > (dwarf2_get_pc_bounds): Use attr_value_as_address to get > the low and high addresses. Slight rework of the handling > of the high pc being a constant form, and limit it to > DWARF verson 4 or higher. > (dwarf2_record_block_ranges): Likewise. > (read_partial_die): Likewise. > (new_symbol_full): Use attr_value_as_address in place of DW_ADDR. > > gdb/testsuite/ChangeLog: > > * gdb.dwarf2/dw2-abs-hi-pc-hello-dbg.S: New file. > * gdb.dwarf2/dw2-abs-hi-pc-hello.c: New file. > * gdb.dwarf2/dw2-abs-hi-pc-world-dbg.S: New file. > * gdb.dwarf2/dw2-abs-hi-pc-world.c: New file. > * gdb.dwarf2/dw2-abs-hi-pc.c: New file. > * gdb.dwarf2/dw2-abs-hi-pc.exp: New file. FYI: This patch has now been pushed. Thanks again to MarkW for all the insightful comments. -- Joel