* New ARI warning Tue Jan 21 01:52:58 UTC 2014
@ 2014-01-21 1:53 GDB Administrator
2014-01-23 6:02 ` Joel Brobecker
0 siblings, 1 reply; 4+ messages in thread
From: GDB Administrator @ 2014-01-21 1:53 UTC (permalink / raw)
To: gdb-patches
52a53
> gdb/cli/cli-decode.c:1402: deprecated: deprecated warn_user: Do not use deprecated warn_user, see declaration for details
gdb/cli/cli-decode.c:1402: if (found->deprecated_warn_user)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: New ARI warning Tue Jan 21 01:52:58 UTC 2014
2014-01-21 1:53 New ARI warning Tue Jan 21 01:52:58 UTC 2014 GDB Administrator
@ 2014-01-23 6:02 ` Joel Brobecker
2014-01-23 6:18 ` Yao Qi
0 siblings, 1 reply; 4+ messages in thread
From: Joel Brobecker @ 2014-01-23 6:02 UTC (permalink / raw)
To: GDB Administrator; +Cc: gdb-patches
> > gdb/cli/cli-decode.c:1402: deprecated: deprecated warn_user: Do not use deprecated warn_user, see declaration for details
> gdb/cli/cli-decode.c:1402: if (found->deprecated_warn_user)
Does anyone understand this violation?
This is what the declaration in cli/cli-decode.h looks like:
/* The user needs to be warned that this is a deprecated command.
The user should only be warned the first time a command is
used. */
unsigned int deprecated_warn_user : 1;
This bit is set when a command is deprecated via deprecate_cmd,
and seems to be an integral part of how we manage deprecated
commands.
So I'm wondering if the warning may have been about something else?
Or maybe I'm missing something?
Thanks,
--
Joel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: New ARI warning Tue Jan 21 01:52:58 UTC 2014
2014-01-23 6:02 ` Joel Brobecker
@ 2014-01-23 6:18 ` Yao Qi
2014-01-23 7:14 ` Joel Brobecker
0 siblings, 1 reply; 4+ messages in thread
From: Yao Qi @ 2014-01-23 6:18 UTC (permalink / raw)
To: Joel Brobecker; +Cc: GDB Administrator, gdb-patches
On 01/23/2014 02:02 PM, Joel Brobecker wrote:
> Does anyone understand this violation?
>
> This is what the declaration in cli/cli-decode.h looks like:
>
> /* The user needs to be warned that this is a deprecated command.
> The user should only be warned the first time a command is
> used. */
>
> unsigned int deprecated_warn_user : 1;
>
> This bit is set when a command is deprecated via deprecate_cmd,
> and seems to be an integral part of how we manage deprecated
> commands.
>
> So I'm wondering if the warning may have been about something else?
> Or maybe I'm missing something?
I am not familiar with ARI, but looks like it is a false alarm of
deprecated rule. ARI thinks "deprecated_warn_user" is a deprecated
"warn_user", but it isn't.
--
Yao (é½å°§)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: New ARI warning Tue Jan 21 01:52:58 UTC 2014
2014-01-23 6:18 ` Yao Qi
@ 2014-01-23 7:14 ` Joel Brobecker
0 siblings, 0 replies; 4+ messages in thread
From: Joel Brobecker @ 2014-01-23 7:14 UTC (permalink / raw)
To: Yao Qi; +Cc: GDB Administrator, gdb-patches
> I am not familiar with ARI, but looks like it is a false alarm of
> deprecated rule. ARI thinks "deprecated_warn_user" is a deprecated
> "warn_user", but it isn't.
I think you're right. Somehow, the message read well enought that
it seemed like it was a check specific to that one symbol.
--
Joel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-01-23 7:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-21 1:53 New ARI warning Tue Jan 21 01:52:58 UTC 2014 GDB Administrator
2014-01-23 6:02 ` Joel Brobecker
2014-01-23 6:18 ` Yao Qi
2014-01-23 7:14 ` Joel Brobecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox