New ARI warning Wed Dec 18 01:52:57 UTC 2013

New ARI warning Wed Dec 18 01:52:57 UTC 2013

[GDB Administrator]

834a835
> gdb/value.c:383: code: OP eol: Do not use &&, or || at the end of a line
gdb/value.c:383:	  && t->length == (TARGET_CHAR_BIT *

Re: New ARI warning Wed Dec 18 01:52:57 UTC 2013

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

> 834a835
> > gdb/value.c:383: code: OP eol: Do not use &&, or || at the end of a line
> gdb/value.c:383:	  && t->length == (TARGET_CHAR_BIT *

This was looked easy to fix, so I just went ahead and did it:

gdb/ChangeLog:

        * value.c (value_entirely_unavailable): ARI fix: Move trailing
        binary operator to the next line.  No actual code change.

Tested on x86_64-linux by simply rebuilding GDB.

-- 
Joel

[-- Attachment #2: 0001-ARI-fix-in-value.c-value_entirely_unavailable.patch --]
[-- Type: text/x-diff, Size: 1374 bytes --]

From 64c46ce4ace879a65e62933afac2f540ffbc40aa Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Wed, 18 Dec 2013 06:42:49 +0400
Subject: [PATCH] ARI fix in value.c::value_entirely_unavailable

gdb/ChangeLog:

        * value.c (value_entirely_unavailable): ARI fix: Move trailing
        binary operator to the next line.  No actual code change.
---
 gdb/ChangeLog | 5 +++++
 gdb/value.c   | 4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 71cf9c6..e9cb6ca 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2013-12-18  Joel Brobecker  <brobecker@adacore.com>
+
+	* value.c (value_entirely_unavailable): ARI fix: Move trailing
+	binary operator to the next line.  No actual code change.
+
 2013-12-17  Pedro Alves  <palves@redhat.com>
 
 	* frame.h (enum frame_id_stack_status): New enum.
diff --git a/gdb/value.c b/gdb/value.c
index 66adaca..25c9f32 100644
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -380,8 +380,8 @@ value_entirely_unavailable (struct value *value)
       struct range *t = VEC_index (range_s, value->unavailable, 0);
 
       if (t->offset == 0
-	  && t->length == (TARGET_CHAR_BIT *
-			   TYPE_LENGTH (value_enclosing_type (value))))
+	  && t->length == (TARGET_CHAR_BIT
+			   * TYPE_LENGTH (value_enclosing_type (value))))
 	return 1;
     }
 
-- 
1.8.1.2