From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31706 invoked by alias); 18 Dec 2013 02:47:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31693 invoked by uid 89); 18 Dec 2013 02:47:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 18 Dec 2013 02:47:47 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A3CFF1167B2 for ; Tue, 17 Dec 2013 21:48:25 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 6Qa-X9KMiDk3 for ; Tue, 17 Dec 2013 21:48:25 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 37BD71167B1 for ; Tue, 17 Dec 2013 21:48:25 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id B6AD4E18B1; Wed, 18 Dec 2013 06:47:40 +0400 (RET) Date: Wed, 18 Dec 2013 02:47:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: Re: New ARI warning Wed Dec 18 01:52:57 UTC 2013 Message-ID: <20131218024740.GB3493@adacore.com> References: <20131218015257.GA31623@sourceware.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="Q68bSM7Ycu6FN28Q" Content-Disposition: inline In-Reply-To: <20131218015257.GA31623@sourceware.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-12/txt/msg00680.txt.bz2 --Q68bSM7Ycu6FN28Q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 420 > 834a835 > > gdb/value.c:383: code: OP eol: Do not use &&, or || at the end of a line > gdb/value.c:383: && t->length == (TARGET_CHAR_BIT * This was looked easy to fix, so I just went ahead and did it: gdb/ChangeLog: * value.c (value_entirely_unavailable): ARI fix: Move trailing binary operator to the next line. No actual code change. Tested on x86_64-linux by simply rebuilding GDB. -- Joel --Q68bSM7Ycu6FN28Q Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-ARI-fix-in-value.c-value_entirely_unavailable.patch" Content-length: 1375 >From 64c46ce4ace879a65e62933afac2f540ffbc40aa Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Wed, 18 Dec 2013 06:42:49 +0400 Subject: [PATCH] ARI fix in value.c::value_entirely_unavailable gdb/ChangeLog: * value.c (value_entirely_unavailable): ARI fix: Move trailing binary operator to the next line. No actual code change. --- gdb/ChangeLog | 5 +++++ gdb/value.c | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 71cf9c6..e9cb6ca 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2013-12-18 Joel Brobecker + + * value.c (value_entirely_unavailable): ARI fix: Move trailing + binary operator to the next line. No actual code change. + 2013-12-17 Pedro Alves * frame.h (enum frame_id_stack_status): New enum. diff --git a/gdb/value.c b/gdb/value.c index 66adaca..25c9f32 100644 --- a/gdb/value.c +++ b/gdb/value.c @@ -380,8 +380,8 @@ value_entirely_unavailable (struct value *value) struct range *t = VEC_index (range_s, value->unavailable, 0); if (t->offset == 0 - && t->length == (TARGET_CHAR_BIT * - TYPE_LENGTH (value_enclosing_type (value)))) + && t->length == (TARGET_CHAR_BIT + * TYPE_LENGTH (value_enclosing_type (value)))) return 1; } -- 1.8.1.2 --Q68bSM7Ycu6FN28Q--