From: Joel Brobecker <brobecker@adacore.com>
To: Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][commit/obvious] Fix argument type on gdbsim_detach prototype.
Date: Mon, 11 Nov 2013 14:42:00 -0000 [thread overview]
Message-ID: <20131111141829.GA3481@adacore.com> (raw)
In-Reply-To: <1384175693-18100-1-git-send-email-emachado@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 526 bytes --]
> 2013-11-11 Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
>
> * remote-sim.c (gdbsim_detach): Fix prototype.
Thanks!
I just noticed that one line then became too long. So I pushed
a checkin of my own as well...
> -static void gdbsim_detach (struct target_ops *ops, char *args, int from_tty);
> +static void gdbsim_detach (struct target_ops *ops, const char *args, int from_tty);
gdb/ChangeLog:
* remote-sim.c (gdbsim_detach): Break declaration into
shorter lines. No code change.
--
Joel
[-- Attachment #2: 0001-Minor-reformatting-in-remote-sim.c-gdbsim_detach-dec.patch --]
[-- Type: text/x-diff, Size: 1354 bytes --]
From 8ca5801b3a05240125a79cd5ba090c98dcc584f8 Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Mon, 11 Nov 2013 18:13:40 +0400
Subject: [PATCH] Minor reformatting in remote-sim.c (gdbsim_detach
declaration).
gdb/ChangeLog:
* remote-sim.c (gdbsim_detach): Break declaration into
shorter lines. No code change.
---
gdb/ChangeLog | 5 +++++
gdb/remote-sim.c | 3 ++-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 5a0d355..a47c14e 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2013-11-11 Joel Brobecker <brobecker@adacore.com>
+
+ * remote-sim.c (gdbsim_detach): Break declaration into
+ shorter lines. No code change.
+
2013-11-11 Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
* remote-sim.c (gdbsim_detach): Fix prototype.
diff --git a/gdb/remote-sim.c b/gdb/remote-sim.c
index f7be6fa..6bf18ab 100644
--- a/gdb/remote-sim.c
+++ b/gdb/remote-sim.c
@@ -78,7 +78,8 @@ static void gdbsim_open (char *args, int from_tty);
static void gdbsim_close (void);
-static void gdbsim_detach (struct target_ops *ops, const char *args, int from_tty);
+static void gdbsim_detach (struct target_ops *ops, const char *args,
+ int from_tty);
static void gdbsim_prepare_to_store (struct regcache *regcache);
--
1.8.1.2
next prev parent reply other threads:[~2013-11-11 14:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 14:18 Edjunior Barbosa Machado
2013-11-11 14:42 ` Joel Brobecker [this message]
2013-11-11 16:27 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131111141829.GA3481@adacore.com \
--to=brobecker@adacore.com \
--cc=emachado@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox