From: Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
To: gdb-patches@sourceware.org
Subject: [PATCH][commit/obvious] Fix argument type on gdbsim_detach prototype.
Date: Mon, 11 Nov 2013 14:18:00 -0000 [thread overview]
Message-ID: <1384175693-18100-1-git-send-email-emachado@linux.vnet.ibm.com> (raw)
Hi,
gdb ppc64 build was failing with the following:
gcc -g3 -mminimal-toc -I. -I../../gdb -I../../gdb/common -I../../gdb/config -DLOCALEDIR="\"/usr/share/locale\"" -DHAVE_CONFIG_H -I../../gdb/../include/opcode -I../../gdb/../opcodes/.. -I../../gdb/../readline/.. -I../bfd -I../../gdb/../bfd -I../../gdb/../include -I../libdecnumber -I../../gdb/../libdecnumber -I../../gdb/gnulib/import -Ibuild-gnulib/import -DTUI=1 -I/usr/include/python2.6 -I/usr/include/python2.6 -Wall -Wdeclaration-after-statement -Wpointer-arith -Wpointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wmissing-prototypes -Wdeclaration-after-statement -Wempty-body -Wmissing-parameter-type -Wold-style-declaration -Wold-style-definition -Wformat-nonliteral -Werror -c -o remote-sim.o -MT remote-sim.o -MMD -MP -MF .deps/remote-sim.Tpo ../../gdb/remote-sim.c
../../gdb/remote-sim.c:820: error: conflicting types for âgdbsim_detachâ
../../gdb/remote-sim.c:81: note: previous declaration of âgdbsim_detachâ was here
make[2]: *** [remote-sim.o] Error 1
I've checked in the obvious patch below that fixed the problem.
Thanks,
--
Edjunior
2013-11-11 Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
* remote-sim.c (gdbsim_detach): Fix prototype.
---
gdb/ChangeLog | 4 ++++
gdb/remote-sim.c | 2 +-
2 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/gdb/remote-sim.c b/gdb/remote-sim.c
index e095035..f7be6fa 100644
--- a/gdb/remote-sim.c
+++ b/gdb/remote-sim.c
@@ -78,7 +78,7 @@ static void gdbsim_open (char *args, int from_tty);
static void gdbsim_close (void);
-static void gdbsim_detach (struct target_ops *ops, char *args, int from_tty);
+static void gdbsim_detach (struct target_ops *ops, const char *args, int from_tty);
static void gdbsim_prepare_to_store (struct regcache *regcache);
--
1.7.1
next reply other threads:[~2013-11-11 13:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 14:18 Edjunior Barbosa Machado [this message]
2013-11-11 14:42 ` Joel Brobecker
2013-11-11 16:27 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384175693-18100-1-git-send-email-emachado@linux.vnet.ibm.com \
--to=emachado@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox