From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6809 invoked by alias); 11 Nov 2013 14:18:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6797 invoked by uid 89); 11 Nov 2013 14:18:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from Unknown (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 11 Nov 2013 14:18:42 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A8D4C116285; Mon, 11 Nov 2013 09:19:05 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 7A7JjSgmmk2c; Mon, 11 Nov 2013 09:19:05 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 3FD2511621D; Mon, 11 Nov 2013 09:19:05 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id CA1AFE991D; Mon, 11 Nov 2013 18:18:29 +0400 (RET) Date: Mon, 11 Nov 2013 14:42:00 -0000 From: Joel Brobecker To: Edjunior Barbosa Machado Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][commit/obvious] Fix argument type on gdbsim_detach prototype. Message-ID: <20131111141829.GA3481@adacore.com> References: <1384175693-18100-1-git-send-email-emachado@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nFreZHaLTZJo0R7j" Content-Disposition: inline In-Reply-To: <1384175693-18100-1-git-send-email-emachado@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-11/txt/msg00289.txt.bz2 --nFreZHaLTZJo0R7j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 526 > 2013-11-11 Edjunior Barbosa Machado > > * remote-sim.c (gdbsim_detach): Fix prototype. Thanks! I just noticed that one line then became too long. So I pushed a checkin of my own as well... > -static void gdbsim_detach (struct target_ops *ops, char *args, int from_tty); > +static void gdbsim_detach (struct target_ops *ops, const char *args, int from_tty); gdb/ChangeLog: * remote-sim.c (gdbsim_detach): Break declaration into shorter lines. No code change. -- Joel --nFreZHaLTZJo0R7j Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-Minor-reformatting-in-remote-sim.c-gdbsim_detach-dec.patch" Content-length: 1355 >From 8ca5801b3a05240125a79cd5ba090c98dcc584f8 Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Mon, 11 Nov 2013 18:13:40 +0400 Subject: [PATCH] Minor reformatting in remote-sim.c (gdbsim_detach declaration). gdb/ChangeLog: * remote-sim.c (gdbsim_detach): Break declaration into shorter lines. No code change. --- gdb/ChangeLog | 5 +++++ gdb/remote-sim.c | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 5a0d355..a47c14e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2013-11-11 Joel Brobecker + + * remote-sim.c (gdbsim_detach): Break declaration into + shorter lines. No code change. + 2013-11-11 Edjunior Barbosa Machado * remote-sim.c (gdbsim_detach): Fix prototype. diff --git a/gdb/remote-sim.c b/gdb/remote-sim.c index f7be6fa..6bf18ab 100644 --- a/gdb/remote-sim.c +++ b/gdb/remote-sim.c @@ -78,7 +78,8 @@ static void gdbsim_open (char *args, int from_tty); static void gdbsim_close (void); -static void gdbsim_detach (struct target_ops *ops, const char *args, int from_tty); +static void gdbsim_detach (struct target_ops *ops, const char *args, + int from_tty); static void gdbsim_prepare_to_store (struct regcache *regcache); -- 1.8.1.2 --nFreZHaLTZJo0R7j--