From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: ooprala@redhat.com
Cc: gdb-patches@sourceware.org, tromey@redhat.com
Subject: Re: [PATCH 01/18] poison "class"
Date: Sun, 20 Oct 2013 19:13:00 -0000 [thread overview]
Message-ID: <201310201912.r9KJCuKB015989@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <1381339053-14519-2-git-send-email-ooprala@redhat.com> (message from Ondrej Oprala on Wed, 9 Oct 2013 19:17:16 +0200)
> From: Ondrej Oprala <ooprala@redhat.com>
> Date: Wed, 9 Oct 2013 19:17:16 +0200
>
> From: Tom Tromey <tromey@redhat.com>
>
> * amd64-tdep.c (klass) : Renamed from class.
> * c-exp.y(klass) : Likewise.
> * cli/cli-cmds.c(klass) : Likewise.
> * cli/cli-decode.c(klass) : Likewise.
> * cli/cli-decode.h(klass) : Likewise.
> * cli/cli-script.c(klass) : Likewise.
> * cli/cli-setshow.c(klass) : Likewise.
> * command.h(klass) : Likewise.
> * mdebugread.c(klass) : Likewise.
> * objc-lang.c(klass) : Likewise.
> * parser-defs.h(klass) : Likewise.
> * psymtab.c(klass) : Likewise.
> * python/py-symbol.c(klass) : Likewise.
> * top.c(klass) : Likewise.
I strongly object to the deliberate misspelling of "class" that this
diff introduces. Unless we're actually make the decision to rewrite
GDB in C++ (to which I strongly object in the first place) I don't
think this (and other) uglification diffs should go in.
next prev parent reply other threads:[~2013-10-20 19:13 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 17:17 [PATCH 00/18] -Wc++-compat patches Ondrej Oprala
2013-10-09 17:17 ` [PATCH 02/18] poison "new" Ondrej Oprala
2013-10-10 12:23 ` Pedro Alves
2013-10-10 19:15 ` Jan Kratochvil
2013-10-09 17:17 ` [PATCH 01/18] poison "class" Ondrej Oprala
2013-10-09 21:45 ` Stan Shebs
2013-10-20 19:13 ` Mark Kettenis [this message]
2013-10-24 17:57 ` Joel Brobecker
2013-10-24 18:21 ` Stan Shebs
2013-10-09 17:17 ` [PATCH 03/18] poison "this" Ondrej Oprala
2013-10-09 17:25 ` Tom Tromey
2013-10-10 12:25 ` Pedro Alves
2013-10-09 17:18 ` [PATCH 11/18] poison "template" Ondrej Oprala
2013-10-13 17:21 ` Jan Kratochvil
2013-10-09 17:18 ` [PATCH 12/18] poison "try" Ondrej Oprala
2013-10-13 17:22 ` Jan Kratochvil
2013-10-09 17:18 ` [PATCH 09/18] poison "namespace" Ondrej Oprala
2013-10-13 17:18 ` Jan Kratochvil
2013-10-09 17:18 ` [PATCH 16/18] fix up gdbtypes.h Ondrej Oprala
2013-10-13 17:32 ` Jan Kratochvil
2013-10-09 17:18 ` [PATCH 14/18] poison "using" Ondrej Oprala
2013-10-13 17:25 ` Jan Kratochvil
2013-10-09 17:18 ` [PATCH 13/18] poison "typename" Ondrej Oprala
2013-10-13 17:24 ` Jan Kratochvil
2013-10-09 17:18 ` [PATCH 07/18] poison "explicit" Ondrej Oprala
2013-10-13 16:58 ` Jan Kratochvil
2013-10-09 17:18 ` [PATCH 10/18] poison "operator" Ondrej Oprala
2013-10-13 17:20 ` Jan Kratochvil
2013-10-09 17:18 ` [PATCH 04/18] poison "public" Ondrej Oprala
2013-10-13 16:39 ` Jan Kratochvil
2013-10-09 17:18 ` [PATCH 15/18] fix up vec Ondrej Oprala
2013-10-13 17:29 ` Jan Kratochvil
2013-10-09 17:18 ` [PATCH 18/18] un-nest enum pvk Ondrej Oprala
2013-10-13 17:37 ` Jan Kratochvil
2013-10-09 17:18 ` [PATCH 06/18] poison "delete" Ondrej Oprala
2013-10-13 16:47 ` Jan Kratochvil
2013-10-09 17:18 ` [PATCH 17/18] fix gdbarch buglet Ondrej Oprala
2013-10-13 17:35 ` Jan Kratochvil
2013-10-09 17:53 ` [PATCH 08/18] poison "mutable" Ondrej Oprala
2013-10-13 17:00 ` Jan Kratochvil
2013-10-13 17:16 ` Jan Kratochvil
2013-10-09 18:09 ` [PATCH 05/18] poison "private" Ondrej Oprala
2013-10-13 16:45 ` Jan Kratochvil
2013-10-14 8:49 ` Pedro Alves
2013-10-14 15:36 ` Tom Tromey
2013-10-14 16:19 ` Pedro Alves
2013-10-09 18:56 ` [PATCH 00/18] -Wc++-compat patches Tom Tromey
2013-10-09 19:43 ` Ondrej Oprala
2013-10-21 15:37 [PATCH 00/18] -Wc++-compat patches v2.0 Ondrej Oprala
2013-10-21 15:37 ` [PATCH 01/18] poison "class" Ondrej Oprala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201310201912.r9KJCuKB015989@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=ooprala@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox