From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2844 invoked by alias); 20 Oct 2013 19:13:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2562 invoked by uid 89); 20 Oct 2013 19:13:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: glazunov.sibelius.xs4all.nl Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sun, 20 Oct 2013 19:13:04 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id r9KJCvZ3020756; Sun, 20 Oct 2013 21:12:57 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id r9KJCuKB015989; Sun, 20 Oct 2013 21:12:56 +0200 (CEST) Date: Sun, 20 Oct 2013 19:13:00 -0000 Message-Id: <201310201912.r9KJCuKB015989@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: ooprala@redhat.com CC: gdb-patches@sourceware.org, tromey@redhat.com In-reply-to: <1381339053-14519-2-git-send-email-ooprala@redhat.com> (message from Ondrej Oprala on Wed, 9 Oct 2013 19:17:16 +0200) Subject: Re: [PATCH 01/18] poison "class" References: <1381339053-14519-1-git-send-email-ooprala@redhat.com> <1381339053-14519-2-git-send-email-ooprala@redhat.com> X-SW-Source: 2013-10/txt/msg00609.txt.bz2 > From: Ondrej Oprala > Date: Wed, 9 Oct 2013 19:17:16 +0200 > > From: Tom Tromey > > * amd64-tdep.c (klass) : Renamed from class. > * c-exp.y(klass) : Likewise. > * cli/cli-cmds.c(klass) : Likewise. > * cli/cli-decode.c(klass) : Likewise. > * cli/cli-decode.h(klass) : Likewise. > * cli/cli-script.c(klass) : Likewise. > * cli/cli-setshow.c(klass) : Likewise. > * command.h(klass) : Likewise. > * mdebugread.c(klass) : Likewise. > * objc-lang.c(klass) : Likewise. > * parser-defs.h(klass) : Likewise. > * psymtab.c(klass) : Likewise. > * python/py-symbol.c(klass) : Likewise. > * top.c(klass) : Likewise. I strongly object to the deliberate misspelling of "class" that this diff introduces. Unless we're actually make the decision to rewrite GDB in C++ (to which I strongly object in the first place) I don't think this (and other) uglification diffs should go in.